1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

assert: provide info about actual error

Browse Source 
In case a error is caught in `assert.doesNotThrow` or
`assert.doesNotReject` it will now also indicate what the real
error message was.

PR-URL: https://github.com/nodejs/node/pull/19884
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Ruben Bridgewater 2018-04-09 03:57:40 +02:00
parent 5a8fcd0d94
commit 2bee7996a5
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
3 changed files with 13 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/assert.js
View File

@ -510,7 +510,8 @@ function expectsNoError(stackStartFn, actual, error, message) {
actual, actual,
expected: error, expected: error,
operator: stackStartFn.name, operator: stackStartFn.name,
message: `Got unwanted ${fnType}${details}\n${actual && actual.message}`, message: `Got unwanted ${fnType}${details}\n` +
`Actual message: "${actual && actual.message}"`,
stackStartFn stackStartFn
}); });
} }

3
test/parallel/test-assert-async.js
View File

@ -34,7 +34,8 @@ common.crashOnUnhandledRejection();
assert(err instanceof assert.AssertionError, assert(err instanceof assert.AssertionError,
`${err.name} is not instance of AssertionError`); `${err.name} is not instance of AssertionError`);
assert.strictEqual(err.code, 'ERR_ASSERTION'); assert.strictEqual(err.code, 'ERR_ASSERTION');
assert(/^Got unwanted rejection\.\n$/.test(err.message)); assert.strictEqual(err.message,
'Got unwanted rejection.\nActual message: ""');
assert.strictEqual(err.operator, 'doesNotReject'); assert.strictEqual(err.operator, 'doesNotReject');
assert.ok(!err.stack.includes('at Function.doesNotReject')); assert.ok(!err.stack.includes('at Function.doesNotReject'));
return true; return true;

25
test/parallel/test-assert.js
View File

@ -124,29 +124,22 @@ assert.throws(() => thrower(TypeError));
assert.ok(threw, 'a.doesNotThrow is not catching type matching errors'); assert.ok(threw, 'a.doesNotThrow is not catching type matching errors');
} }
common.expectsError( assert.throws(
() => a.doesNotThrow(() => thrower(Error), 'user message'), () => a.doesNotThrow(() => thrower(Error), 'user message'),
{ {
type: a.AssertionError, name: 'AssertionError [ERR_ASSERTION]',
code: 'ERR_ASSERTION', code: 'ERR_ASSERTION',
operator: 'doesNotThrow', operator: 'doesNotThrow',
message: 'Got unwanted exception: user message\n[object Object]' message: 'Got unwanted exception: user message\n' +
'Actual message: "[object Object]"'
} }
); );
common.expectsError( assert.throws(
() => a.doesNotThrow(() => thrower(Error), 'user message'),
{
code: 'ERR_ASSERTION',
message: /Got unwanted exception: user message\n\[object Object\]/
}
);
common.expectsError(
() => a.doesNotThrow(() => thrower(Error)), () => a.doesNotThrow(() => thrower(Error)),
{ {
code: 'ERR_ASSERTION', code: 'ERR_ASSERTION',
message: /Got unwanted exception\.\n\[object Object\]/ message: 'Got unwanted exception.\nActual message: "[object Object]"'
} }
); );
@ -833,13 +826,13 @@ common.expectsError(
// eslint-disable-next-line no-throw-literal // eslint-disable-next-line no-throw-literal
assert.throws(() => { throw undefined; }, /undefined/); assert.throws(() => { throw undefined; }, /undefined/);
common.expectsError( assert.throws(
// eslint-disable-next-line no-throw-literal // eslint-disable-next-line no-throw-literal
() => a.doesNotThrow(() => { throw undefined; }), () => a.doesNotThrow(() => { throw undefined; }),
{ {
type: assert.AssertionError, name: 'AssertionError [ERR_ASSERTION]',
code: 'ERR_ASSERTION', code: 'ERR_ASSERTION',
message: 'Got unwanted exception.\nundefined' message: 'Got unwanted exception.\nActual message: "undefined"'
} }
); );
} }