From 2bbeec73af537cb8c62a31067b13d5c9219e926c Mon Sep 17 00:00:00 2001 From: "xinglong.wangwxl" Date: Sun, 16 Jul 2017 15:06:50 +0800 Subject: [PATCH] test: improve regexps for error checking MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit test/parallel/test-catpto-random.js contains an object called errorMesssage that contains regular expressions.They are only partially matching regular expressions. Make them match the entire error message. PR-URL: https://github.com/nodejs/node/pull/14271 Reviewed-By: Rich Trott Reviewed-By: Colin Ihrig Reviewed-By: Gibson Fahnestock Reviewed-By: Tobias Nießen Reviewed-By: Gireesh Punathil --- test/parallel/test-crypto-random.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/parallel/test-crypto-random.js b/test/parallel/test-crypto-random.js index eec6f00b542..81b46e7bd41 100644 --- a/test/parallel/test-crypto-random.js +++ b/test/parallel/test-crypto-random.js @@ -140,12 +140,12 @@ const expectedErrorRegexp = /^TypeError: size must be a number >= 0$/; new Uint8Array(new Array(10).fill(0)) ]; const errMessages = { - offsetNotNumber: /offset must be a number/, - offsetOutOfRange: /offset out of range/, - offsetNotUInt32: /offset must be a uint32/, - sizeNotNumber: /size must be a number/, - sizeNotUInt32: /size must be a uint32/, - bufferTooSmall: /buffer too small/, + offsetNotNumber: /^TypeError: offset must be a number$/, + offsetOutOfRange: /^RangeError: offset out of range$/, + offsetNotUInt32: /^TypeError: offset must be a uint32$/, + sizeNotNumber: /^TypeError: size must be a number$/, + sizeNotUInt32: /^TypeError: size must be a uint32$/, + bufferTooSmall: /^RangeError: buffer too small$/, }; for (const buf of bufs) {