From 2ba84606a68954ff48cefc176f65b21264f64cc3 Mon Sep 17 00:00:00 2001 From: Phillip Johnsen Date: Sat, 11 Jul 2015 00:13:59 +0200 Subject: [PATCH] path: assert path.join() arguments equally Re-use `assertPath()` when asserting path argument types in `join()` as throughout the rest of the `path` module. This also ensures the same error message generated for posix as for win32. PR-URL: https://github.com/nodejs/io.js/pull/2159 Reviewed-By: Roman Reiss --- lib/path.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/path.js b/lib/path.js index 69e7992c013..e0c5bcaa1c1 100644 --- a/lib/path.js +++ b/lib/path.js @@ -477,9 +477,7 @@ posix.join = function() { var path = ''; for (var i = 0; i < arguments.length; i++) { var segment = arguments[i]; - if (typeof segment !== 'string') { - throw new TypeError('Arguments to path.join must be strings'); - } + assertPath(segment); if (segment) { if (!path) { path += segment;