1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: prevent displaying empty version picker

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/15420
Fixes: https://github.com/nodejs/node/issues/15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Chris Young 2017-09-13 17:37:32 -07:00 committed by Ruben Bridgewater
parent 19766547fa
commit 2b7b9f24d9
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
3 changed files with 25 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
doc/api_assets/style.css
View File

@ -91,6 +91,15 @@ em code {
#gtoc li { #gtoc li {
display: inline; display: inline;
border-right: 1px #000 solid;
margin-right: 0.4em;
padding-right: 0.4em;
}
#gtoc li:last-child {
border-right: none;
margin-right: 0;
padding-right: 0;
} }
li.version-picker { li.version-picker {
@ -118,6 +127,8 @@ ol.version-picker {
#gtoc ol.version-picker li { #gtoc ol.version-picker li {
display: block; display: block;
border-right: 0;
margin-right: 0;
} }
ol.version-picker li a { ol.version-picker li a {

9
doc/template.html
View File

@ -25,18 +25,15 @@
<div id="gtoc"> <div id="gtoc">
<ul> <ul>
<li> <li>
<a href="index.html" name="toc">Index</a> | <a href="index.html" name="toc">Index</a>
</li> </li>
<li> <li>
<a href="all.html">View on single page</a> | <a href="all.html">View on single page</a>
</li> </li>
<li> <li>
<a href="__FILENAME__.json">View as JSON</a> | <a href="__FILENAME__.json">View as JSON</a>
</li> </li>
<li class="version-picker">
<a href="#">View another version <span>&#x25bc;</span></a>
__ALTDOCS__ __ALTDOCS__
</li>
</ul> </ul>
</div> </div>
<hr> <hr>

12
tools/doc/html.js
View File

@ -232,9 +232,17 @@ function altDocs(filename) {
return html + '</a></li>'; return html + '</a></li>';
} }
const lis = (vs) => vs.filter(lte).map(li).join('\n'); const lis = versions.filter(lte).map(li).join('\n');
return `<ol class="version-picker">${lis(versions)}</ol>`; if (!lis.length)
return '';
return `
<li class="version-picker">
<a href="#">View another version <span>&#x25bc;</span></a>
<ol class="version-picker">${lis}</ol>
</li>
`;
} }
// handle general body-text replacements // handle general body-text replacements