test: remove unused vars in ChildProcess tests

In addition to removing unused vars, this also fixes an instance where
booleans were set presumably to check something but then never used.
This now confirms that the events that were setting the booleans are
fired.

PR-URL: https://github.com/nodejs/node/pull/4425
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Rich Trott 2015-12-25 21:52:52 -08:00
parent fd551c3f29
commit 2b1999b7c7
12 changed files with 5 additions and 25 deletions

View File

@ -2,8 +2,6 @@
var common = require('../common'); var common = require('../common');
var assert = require('assert'); var assert = require('assert');
var spawn = require('child_process').spawn;
var pwd_called = false; var pwd_called = false;
var childClosed = false; var childClosed = false;
var childExited = false; var childExited = false;

View File

@ -1,8 +1,6 @@
'use strict'; 'use strict';
var common = require('../common'); var common = require('../common');
var assert = require('assert'); var assert = require('assert');
var spawn = require('child_process').spawn;
var path = require('path');
var returns = 0; var returns = 0;

View File

@ -9,7 +9,7 @@ var success_count = 0;
var str = 'hello'; var str = 'hello';
// default encoding // default encoding
var child = exec('echo ' + str, function(err, stdout, stderr) { exec('echo ' + str, function(err, stdout, stderr) {
assert.ok('string', typeof(stdout), 'Expected stdout to be a string'); assert.ok('string', typeof(stdout), 'Expected stdout to be a string');
assert.ok('string', typeof(stderr), 'Expected stderr to be a string'); assert.ok('string', typeof(stderr), 'Expected stderr to be a string');
assert.equal(str + os.EOL, stdout); assert.equal(str + os.EOL, stdout);

View File

@ -16,7 +16,7 @@ if (common.isWindows) {
dir = '/dev'; dir = '/dev';
} }
var child = exec(pwdcommand, {cwd: dir}, function(err, stdout, stderr) { exec(pwdcommand, {cwd: dir}, function(err, stdout, stderr) {
if (err) { if (err) {
error_count++; error_count++;
console.log('error!: ' + err.code); console.log('error!: ' + err.code);

View File

@ -25,7 +25,6 @@ if (common.isWindows) {
} }
if (process.argv[2] === 'child') { if (process.argv[2] === 'child') {
var childCollected = 0;
var server; var server;
process.on('message', function removeMe(msg, clusterServer) { process.on('message', function removeMe(msg, clusterServer) {

View File

@ -1,6 +1,5 @@
'use strict'; 'use strict';
var assert = require('assert'); var assert = require('assert');
var cp = require('child_process');
var fs = require('fs'); var fs = require('fs');
var path = require('path'); var path = require('path');
var common = require('../common'); var common = require('../common');

View File

@ -1,6 +1,5 @@
'use strict'; 'use strict';
require('../common'); require('../common');
var assert = require('assert');
var fork = require('child_process').fork; var fork = require('child_process').fork;
if (process.argv[2] === 'child') { if (process.argv[2] === 'child') {

View File

@ -1,6 +1,5 @@
'use strict'; 'use strict';
var common = require('../common'); var common = require('../common');
var fs = require('fs');
var spawn = require('child_process').spawn; var spawn = require('child_process').spawn;
var assert = require('assert'); var assert = require('assert');

View File

@ -18,30 +18,20 @@ var response = '';
var exitStatus = -1; var exitStatus = -1;
var closed = false; var closed = false;
var gotStdoutEOF = false;
cat.stdout.setEncoding('utf8'); cat.stdout.setEncoding('utf8');
cat.stdout.on('data', function(chunk) { cat.stdout.on('data', function(chunk) {
console.log('stdout: ' + chunk); console.log('stdout: ' + chunk);
response += chunk; response += chunk;
}); });
cat.stdout.on('end', function() { cat.stdout.on('end', common.mustCall(function() {}));
gotStdoutEOF = true;
});
var gotStderrEOF = false;
cat.stderr.on('data', function(chunk) { cat.stderr.on('data', function(chunk) {
// shouldn't get any stderr output // shouldn't get any stderr output
assert.ok(false); assert.ok(false);
}); });
cat.stderr.on('end', function(chunk) { cat.stderr.on('end', common.mustCall(function() {}));
gotStderrEOF = true;
});
cat.on('exit', function(status) { cat.on('exit', function(status) {
console.log('exit event'); console.log('exit event');

View File

@ -31,5 +31,5 @@ function grandparent() {
function parent() { function parent() {
// should not immediately exit. // should not immediately exit.
var child = common.spawnCat({ stdio: 'inherit' }); common.spawnCat({ stdio: 'inherit' });
} }

View File

@ -1,7 +1,6 @@
'use strict'; 'use strict';
var common = require('../common'); var common = require('../common');
var assert = require('assert'); var assert = require('assert');
var spawn = require('child_process').spawn;
var options = {stdio: ['pipe']}; var options = {stdio: ['pipe']};
var child = common.spawnPwd(options); var child = common.spawnPwd(options);

View File

@ -1,7 +1,6 @@
'use strict'; 'use strict';
var common = require('../common'); var common = require('../common');
var assert = require('assert'); var assert = require('assert');
var path = require('path');
// if child process output to console and exit // if child process output to console and exit
if (process.argv[2] === 'child') { if (process.argv[2] === 'child') {