1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: update test-http-status-reason-invalid-chars to use countdown

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/17342
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This commit is contained in:
Mithun Sasidharan 2017-11-27 11:43:20 +05:30 committed by Jon Moss
parent fff4272fa7
commit 2afd4e779c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/parallel/test-http-status-reason-invalid-chars.js
View File

@ -3,6 +3,7 @@
const common = require('../common'); const common = require('../common');
const assert = require('assert'); const assert = require('assert');
const http = require('http'); const http = require('http');
const Countdown = require('../common/countdown');
function explicit(req, res) { function explicit(req, res) {
assert.throws(() => { assert.throws(() => {
@ -34,13 +35,12 @@ const server = http.createServer((req, res) => {
} }
}).listen(0, common.mustCall(() => { }).listen(0, common.mustCall(() => {
const hostname = 'localhost'; const hostname = 'localhost';
const countdown = new Countdown(2, () => server.close());
const url = `http://${hostname}:${server.address().port}`; const url = `http://${hostname}:${server.address().port}`;
let left = 2;
const check = common.mustCall((res) => { const check = common.mustCall((res) => {
left--;
assert.notStrictEqual(res.headers['content-type'], 'text/html'); assert.notStrictEqual(res.headers['content-type'], 'text/html');
assert.notStrictEqual(res.headers['content-type'], 'gotcha'); assert.notStrictEqual(res.headers['content-type'], 'gotcha');
if (left === 0) server.close(); countdown.dec();
}, 2); }, 2);
http.get(`${url}/explicit`, check).end(); http.get(`${url}/explicit`, check).end();
http.get(`${url}/implicit`, check).end(); http.get(`${url}/implicit`, check).end();