1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: add node::FreeEnvironment public API

Browse Source 
Since debugger::Agent's interface is not exported, third party embedders
will have linking errors if they call Environment's destructor directly.

PR-URL: https://github.com/nodejs/node/pull/3098
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This commit is contained in:
Cheng Zhao 2015-09-28 21:42:25 +08:00 committed by Ben Noordhuis
parent fe77de196c
commit 2ab75b7a42
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/node.cc
View File

@ -3386,6 +3386,13 @@ void LoadEnvironment(Environment* env) {
f->Call(Null(env->isolate()), 1, &arg); f->Call(Null(env->isolate()), 1, &arg);
} }
void FreeEnvironment(Environment* env) {
CHECK_NE(env, nullptr);
env->Dispose();
}
static void PrintHelp(); static void PrintHelp();
static bool ParseDebugOpt(const char* arg) { static bool ParseDebugOpt(const char* arg) {

1
src/node.h
View File

@ -200,6 +200,7 @@ NODE_EXTERN Environment* CreateEnvironment(v8::Isolate* isolate,
int exec_argc, int exec_argc,
const char* const* exec_argv); const char* const* exec_argv);
NODE_EXTERN void LoadEnvironment(Environment* env); NODE_EXTERN void LoadEnvironment(Environment* env);
NODE_EXTERN void FreeEnvironment(Environment* env);
// NOTE: Calling this is the same as calling // NOTE: Calling this is the same as calling
// CreateEnvironment() + LoadEnvironment() from above. // CreateEnvironment() + LoadEnvironment() from above.