test: remove unused arguments from function
Removed the unused arguments of functions defined in file test/parallel/test-http-parser.js. PR-URL: https://github.com/nodejs/node/pull/14931 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
This commit is contained in:
parent
342c5f9d4c
commit
2a97eb61c6
@ -52,7 +52,7 @@ function newParser(type) {
|
|||||||
parser.url += url;
|
parser.url += url;
|
||||||
};
|
};
|
||||||
|
|
||||||
parser[kOnHeadersComplete] = function(info) {
|
parser[kOnHeadersComplete] = function() {
|
||||||
};
|
};
|
||||||
|
|
||||||
parser[kOnBody] = common.mustNotCall('kOnBody should not be called');
|
parser[kOnBody] = common.mustNotCall('kOnBody should not be called');
|
||||||
@ -94,8 +94,7 @@ function expectBody(expected) {
|
|||||||
const request = Buffer.from('GET /hello HTTP/1.1\r\n\r\n');
|
const request = Buffer.from('GET /hello HTTP/1.1\r\n\r\n');
|
||||||
|
|
||||||
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
||||||
method, url, statusCode, statusMessage,
|
method, url) => {
|
||||||
upgrade, shouldKeepAlive) => {
|
|
||||||
assert.strictEqual(versionMajor, 1);
|
assert.strictEqual(versionMajor, 1);
|
||||||
assert.strictEqual(versionMinor, 1);
|
assert.strictEqual(versionMinor, 1);
|
||||||
assert.strictEqual(method, methods.indexOf('GET'));
|
assert.strictEqual(method, methods.indexOf('GET'));
|
||||||
@ -111,7 +110,7 @@ function expectBody(expected) {
|
|||||||
// thrown from parser.execute()
|
// thrown from parser.execute()
|
||||||
//
|
//
|
||||||
|
|
||||||
parser[kOnHeadersComplete] = function(info) {
|
parser[kOnHeadersComplete] = function() {
|
||||||
throw new Error('hello world');
|
throw new Error('hello world');
|
||||||
};
|
};
|
||||||
|
|
||||||
@ -136,8 +135,7 @@ function expectBody(expected) {
|
|||||||
);
|
);
|
||||||
|
|
||||||
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
||||||
method, url, statusCode, statusMessage,
|
method, url, statusCode, statusMessage) => {
|
||||||
upgrade, shouldKeepAlive) => {
|
|
||||||
assert.strictEqual(method, undefined);
|
assert.strictEqual(method, undefined);
|
||||||
assert.strictEqual(versionMajor, 1);
|
assert.strictEqual(versionMajor, 1);
|
||||||
assert.strictEqual(versionMinor, 1);
|
assert.strictEqual(versionMinor, 1);
|
||||||
@ -165,8 +163,7 @@ function expectBody(expected) {
|
|||||||
'HTTP/1.0 200 Connection established\r\n\r\n');
|
'HTTP/1.0 200 Connection established\r\n\r\n');
|
||||||
|
|
||||||
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
||||||
method, url, statusCode, statusMessage,
|
method, url, statusCode, statusMessage) => {
|
||||||
upgrade, shouldKeepAlive) => {
|
|
||||||
assert.strictEqual(versionMajor, 1);
|
assert.strictEqual(versionMajor, 1);
|
||||||
assert.strictEqual(versionMinor, 0);
|
assert.strictEqual(versionMinor, 0);
|
||||||
assert.strictEqual(method, undefined);
|
assert.strictEqual(method, undefined);
|
||||||
@ -199,15 +196,14 @@ function expectBody(expected) {
|
|||||||
|
|
||||||
let seen_body = false;
|
let seen_body = false;
|
||||||
|
|
||||||
const onHeaders = (headers, url) => {
|
const onHeaders = (headers) => {
|
||||||
assert.ok(seen_body); // trailers should come after the body
|
assert.ok(seen_body); // trailers should come after the body
|
||||||
assert.deepStrictEqual(headers,
|
assert.deepStrictEqual(headers,
|
||||||
['Vary', '*', 'Content-Type', 'text/plain']);
|
['Vary', '*', 'Content-Type', 'text/plain']);
|
||||||
};
|
};
|
||||||
|
|
||||||
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
||||||
method, url, statusCode, statusMessage,
|
method, url) => {
|
||||||
upgrade, shouldKeepAlive) => {
|
|
||||||
assert.strictEqual(method, methods.indexOf('POST'));
|
assert.strictEqual(method, methods.indexOf('POST'));
|
||||||
assert.strictEqual(url || parser.url, '/it');
|
assert.strictEqual(url || parser.url, '/it');
|
||||||
assert.strictEqual(versionMajor, 1);
|
assert.strictEqual(versionMajor, 1);
|
||||||
@ -242,8 +238,7 @@ function expectBody(expected) {
|
|||||||
);
|
);
|
||||||
|
|
||||||
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
||||||
method, url, statusCode, statusMessage,
|
method) => {
|
||||||
upgrade, shouldKeepAlive) => {
|
|
||||||
assert.strictEqual(method, methods.indexOf('GET'));
|
assert.strictEqual(method, methods.indexOf('GET'));
|
||||||
assert.strictEqual(versionMajor, 1);
|
assert.strictEqual(versionMajor, 1);
|
||||||
assert.strictEqual(versionMinor, 0);
|
assert.strictEqual(versionMinor, 0);
|
||||||
@ -272,8 +267,7 @@ function expectBody(expected) {
|
|||||||
);
|
);
|
||||||
|
|
||||||
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
||||||
method, url, statusCode, statusMessage,
|
method, url) => {
|
||||||
upgrade, shouldKeepAlive) => {
|
|
||||||
assert.strictEqual(method, methods.indexOf('GET'));
|
assert.strictEqual(method, methods.indexOf('GET'));
|
||||||
assert.strictEqual(url || parser.url, '/foo/bar/baz?quux=42#1337');
|
assert.strictEqual(url || parser.url, '/foo/bar/baz?quux=42#1337');
|
||||||
assert.strictEqual(versionMajor, 1);
|
assert.strictEqual(versionMajor, 1);
|
||||||
@ -307,8 +301,7 @@ function expectBody(expected) {
|
|||||||
);
|
);
|
||||||
|
|
||||||
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
||||||
method, url, statusCode, statusMessage,
|
method, url) => {
|
||||||
upgrade, shouldKeepAlive) => {
|
|
||||||
assert.strictEqual(method, methods.indexOf('POST'));
|
assert.strictEqual(method, methods.indexOf('POST'));
|
||||||
assert.strictEqual(url || parser.url, '/it');
|
assert.strictEqual(url || parser.url, '/it');
|
||||||
assert.strictEqual(versionMajor, 1);
|
assert.strictEqual(versionMajor, 1);
|
||||||
@ -346,8 +339,7 @@ function expectBody(expected) {
|
|||||||
);
|
);
|
||||||
|
|
||||||
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
||||||
method, url, statusCode, statusMessage,
|
method, url) => {
|
||||||
upgrade, shouldKeepAlive) => {
|
|
||||||
assert.strictEqual(method, methods.indexOf('POST'));
|
assert.strictEqual(method, methods.indexOf('POST'));
|
||||||
assert.strictEqual(url || parser.url, '/it');
|
assert.strictEqual(url || parser.url, '/it');
|
||||||
assert.strictEqual(versionMajor, 1);
|
assert.strictEqual(versionMajor, 1);
|
||||||
@ -385,8 +377,7 @@ function expectBody(expected) {
|
|||||||
);
|
);
|
||||||
|
|
||||||
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
||||||
method, url, statusCode, statusMessage,
|
method, url) => {
|
||||||
upgrade, shouldKeepAlive) => {
|
|
||||||
assert.strictEqual(method, methods.indexOf('POST'));
|
assert.strictEqual(method, methods.indexOf('POST'));
|
||||||
assert.strictEqual(url || parser.url, '/it');
|
assert.strictEqual(url || parser.url, '/it');
|
||||||
assert.strictEqual(versionMajor, 1);
|
assert.strictEqual(versionMajor, 1);
|
||||||
@ -445,8 +436,7 @@ function expectBody(expected) {
|
|||||||
|
|
||||||
function test(a, b) {
|
function test(a, b) {
|
||||||
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
||||||
method, url, statusCode, statusMessage,
|
method, url) => {
|
||||||
upgrade, shouldKeepAlive) => {
|
|
||||||
assert.strictEqual(method, methods.indexOf('POST'));
|
assert.strictEqual(method, methods.indexOf('POST'));
|
||||||
assert.strictEqual(url || parser.url, '/helpme');
|
assert.strictEqual(url || parser.url, '/helpme');
|
||||||
assert.strictEqual(versionMajor, 1);
|
assert.strictEqual(versionMajor, 1);
|
||||||
@ -503,8 +493,7 @@ function expectBody(expected) {
|
|||||||
);
|
);
|
||||||
|
|
||||||
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
const onHeadersComplete = (versionMajor, versionMinor, headers,
|
||||||
method, url, statusCode, statusMessage,
|
method, url) => {
|
||||||
upgrade, shouldKeepAlive) => {
|
|
||||||
assert.strictEqual(method, methods.indexOf('POST'));
|
assert.strictEqual(method, methods.indexOf('POST'));
|
||||||
assert.strictEqual(url || parser.url, '/it');
|
assert.strictEqual(url || parser.url, '/it');
|
||||||
assert.strictEqual(versionMajor, 1);
|
assert.strictEqual(versionMajor, 1);
|
||||||
@ -557,8 +546,7 @@ function expectBody(expected) {
|
|||||||
);
|
);
|
||||||
|
|
||||||
const onHeadersComplete1 = (versionMajor, versionMinor, headers,
|
const onHeadersComplete1 = (versionMajor, versionMinor, headers,
|
||||||
method, url, statusCode, statusMessage,
|
method, url) => {
|
||||||
upgrade, shouldKeepAlive) => {
|
|
||||||
assert.strictEqual(method, methods.indexOf('PUT'));
|
assert.strictEqual(method, methods.indexOf('PUT'));
|
||||||
assert.strictEqual(url, '/this');
|
assert.strictEqual(url, '/this');
|
||||||
assert.strictEqual(versionMajor, 1);
|
assert.strictEqual(versionMajor, 1);
|
||||||
@ -569,8 +557,7 @@ function expectBody(expected) {
|
|||||||
};
|
};
|
||||||
|
|
||||||
const onHeadersComplete2 = (versionMajor, versionMinor, headers,
|
const onHeadersComplete2 = (versionMajor, versionMinor, headers,
|
||||||
method, url, statusCode, statusMessage,
|
method, url) => {
|
||||||
upgrade, shouldKeepAlive) => {
|
|
||||||
assert.strictEqual(method, methods.indexOf('POST'));
|
assert.strictEqual(method, methods.indexOf('POST'));
|
||||||
assert.strictEqual(url, '/that');
|
assert.strictEqual(url, '/that');
|
||||||
assert.strictEqual(versionMajor, 1);
|
assert.strictEqual(versionMajor, 1);
|
||||||
|
Loading…
x
Reference in New Issue
Block a user