http: call write callback even if there is no message body

Ensure that the callback of `OutgoingMessage.prototype.write()` is
called when `outgoingMessage._hasBody` is `false` (HEAD method, 204
status code, etc.).

Refs: https://github.com/nodejs/node/pull/27709

PR-URL: https://github.com/nodejs/node/pull/27777
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Luigi Pinca 2019-05-20 10:29:03 +02:00 committed by Rich Trott
parent 74b4986822
commit 2a850cd066
2 changed files with 27 additions and 24 deletions

View File

@ -573,6 +573,7 @@ function write_(msg, chunk, encoding, callback, fromEnd) {
if (!msg._hasBody) {
debug('This type of response MUST NOT have a body. ' +
'Ignoring write() calls.');
if (callback) process.nextTick(callback);
return true;
}

View File

@ -3,35 +3,37 @@
const common = require('../common');
// This test ensures that the callback of `OutgoingMessage.prototype.write()` is
// called also when writing empty chunks.
// called also when writing empty chunks or when the message has no body.
const assert = require('assert');
const http = require('http');
const stream = require('stream');
const expected = ['a', 'b', '', Buffer.alloc(0), 'c'];
const results = [];
for (const method of ['GET, HEAD']) {
const expected = ['a', 'b', '', Buffer.alloc(0), 'c'];
const results = [];
const writable = new stream.Writable({
write(chunk, encoding, callback) {
setImmediate(callback);
}
});
const res = new http.ServerResponse({
method: 'GET',
httpVersionMajor: 1,
httpVersionMinor: 1
});
res.assignSocket(writable);
for (const chunk of expected) {
res.write(chunk, () => {
results.push(chunk);
const writable = new stream.Writable({
write(chunk, encoding, callback) {
callback();
}
});
}
res.end(common.mustCall(() => {
assert.deepStrictEqual(results, expected);
}));
const res = new http.ServerResponse({
method: method,
httpVersionMajor: 1,
httpVersionMinor: 1
});
res.assignSocket(writable);
for (const chunk of expected) {
res.write(chunk, () => {
results.push(chunk);
});
}
res.end(common.mustCall(() => {
assert.deepStrictEqual(results, expected);
}));
}