1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

process: make Symbol.toStringTag writable

Browse Source 
The ecosystem broke by making it non-writable, so this is a good
intermediate fix.

PR-URL: https://github.com/nodejs/node/pull/26488
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Ruben Bridgewater 2019-03-07 11:02:47 +01:00
parent f77555f792
commit 2a7da11ed8
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/internal/bootstrap/node.js
View File

@ -283,7 +283,7 @@ function setupProcessObject() {
EventEmitter.call(process); EventEmitter.call(process);
Object.defineProperty(process, Symbol.toStringTag, { Object.defineProperty(process, Symbol.toStringTag, {
enumerable: false, enumerable: false,
writable: false, writable: true,
configurable: false, configurable: false,
value: 'process' value: 'process'
}); });

1
test/es-module/test-esm-process.mjs
View File

@ -4,3 +4,4 @@ import assert from 'assert';
import process from 'process'; import process from 'process';
assert.strictEqual(Object.prototype.toString.call(process), '[object process]'); assert.strictEqual(Object.prototype.toString.call(process), '[object process]');
assert(Object.getOwnPropertyDescriptor(process, Symbol.toStringTag).writable);