1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix flaky test by removing timer

Browse Source 
This fixes one of the tests that has been failing on CI on freebsd for
a bit by removing an unnecessary timer.

PR-URL: https://github.com/nodejs/node/pull/9199
Fixes: https://github.com/nodejs/node/issues/7929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Evan Lucas 2016-10-19 19:27:08 -05:00
parent 63c47e7189
commit 2a654e4728
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/parallel/test-dgram-send-callback-buffer.js
View File

@ -9,14 +9,9 @@ const client = dgram.createSocket('udp4');
const buf = Buffer.allocUnsafe(256); const buf = Buffer.allocUnsafe(256);
const onMessage = common.mustCall(function(err, bytes) { const onMessage = common.mustCall(function(err, bytes) {
assert.strictEqual(err, null); assert.ifError(err);
assert.equal(bytes, buf.length); assert.strictEqual(bytes, buf.length);
clearTimeout(timer);
client.close(); client.close();
}); });
const timer = setTimeout(function() {
throw new Error('Timeout');
}, common.platformTimeout(200));
client.send(buf, common.PORT, common.localhostIPv4, onMessage); client.send(buf, common.PORT, common.localhostIPv4, onMessage);