build: skip cctest on Windows shared lib build
cctest depends on some internal APIs which don't declare `__declspec(dllexport)` and causes build failure when building node as shared lib on Windows. Since we already have good test coverage in static lib, we decide to skip the cctest in shared lib build on Windows. Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: https://github.com/nodejs/node/pull/21228 Reviewed-By: Refael Ackermann <refack@gmail.com>
This commit is contained in:
parent
4286dcf17f
commit
29cf335e6a
4
node.gyp
4
node.gyp
@ -1002,6 +1002,10 @@
|
||||
['OS=="solaris"', {
|
||||
'ldflags': [ '-I<(SHARED_INTERMEDIATE_DIR)' ]
|
||||
}],
|
||||
# Skip cctest while building shared lib node for Windows
|
||||
[ 'OS=="win" and node_shared=="true"', {
|
||||
'type': 'none',
|
||||
}],
|
||||
],
|
||||
}
|
||||
], # end targets
|
||||
|
@ -529,6 +529,7 @@ if "%test_args%"=="" goto test-v8
|
||||
if "%config%"=="Debug" set test_args=--mode=debug %test_args%
|
||||
if "%config%"=="Release" set test_args=--mode=release %test_args%
|
||||
if defined no_cctest echo Skipping cctest because no-cctest was specified && goto run-test-py
|
||||
if not exist %config%\cctest.exe goto run-test-py
|
||||
echo running 'cctest %cctest_args%'
|
||||
"%config%\cctest" %cctest_args%
|
||||
:run-test-py
|
||||
|
Loading…
x
Reference in New Issue
Block a user