1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: verify arguments length in common.expectsError

Browse Source 
If `common.expectsError` is used as a callback, it will now also
verify that there is only one argument (the expected error).

PR-URL: https://github.com/nodejs/node/pull/20311
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Ruben Bridgewater 2018-04-26 02:14:25 +02:00
parent bb546ac001
commit 29cddb40b2
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/common/index.js
View File

@ -708,6 +708,11 @@ exports.expectsError = function expectsError(fn, settings, exact) {
} }
function innerFn(error) { function innerFn(error) {
if (arguments.length !== 1) {
// Do not use `assert.strictEqual()` to prevent `util.inspect` from
// always being called.
assert.fail(`Expected one argument, got ${util.inspect(arguments)}`);
}
const descriptor = Object.getOwnPropertyDescriptor(error, 'message'); const descriptor = Object.getOwnPropertyDescriptor(error, 'message');
assert.strictEqual(descriptor.enumerable, assert.strictEqual(descriptor.enumerable,
false, 'The error message should be non-enumerable'); false, 'The error message should be non-enumerable');