1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: only assert on first lines of TLS trace

Browse Source 
The TLS trace data is best-effort, and enough can be dropped from pipe
buffers that only the start of the trace is detected. Only assert on the
first line of the trace, it should not get dropped, and it's enough to
check that trace was enabled via CLI.

PR-URL: https://github.com/nodejs/node/pull/28043
Fixes: https://github.com/nodejs/node/issues/27636
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Sam Roberts 2019-06-02 18:19:44 +02:00
parent 5c61c5d152
commit 2976bbd68f
2 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/parallel.status
View File

@ -9,8 +9,6 @@ prefix parallel
test-net-connect-options-port: PASS,FLAKY
# https://github.com/nodejs/node/issues/26401
test-worker-prof: PASS,FLAKY
# https://github.com/nodejs/node/issues/27553
test-tls-enable-trace-cli: PASS,FLAKY
[$system==win32]
test-http2-pipe: PASS,FLAKY

1
test/parallel/test-tls-enable-trace-cli.js
View File

@ -37,7 +37,6 @@ child.on('close', common.mustCall((code, signal) => {
assert.strictEqual(stdout.trim(), '');
assert(/Warning: Enabling --trace-tls can expose sensitive/.test(stderr));
assert(/Sent Record/.test(stderr));
assert(/Received Record/.test(stderr));
}));
function test() {