1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix debug-port-cluster flakiness

Browse Source 
Rewrite the test so that stderr reordering of the child processes won't
confuse the test's expectations.

PR-URL: https://github.com/nodejs/node/pull/4310
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Ben Noordhuis 2015-12-16 15:20:46 +01:00
parent 9e1b7aa874
commit 2859f9ef92
1 changed files with 13 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
test/parallel/test-debug-port-cluster.js
View File

@ -3,47 +3,25 @@ var common = require('../common');
var assert = require('assert'); var assert = require('assert');
var spawn = require('child_process').spawn; var spawn = require('child_process').spawn;
var port = common.PORT + 1337; const PORT_MIN = common.PORT + 1337;
const PORT_MAX = PORT_MIN + 2;
var args = [ var args = [
'--debug=' + port, '--debug=' + PORT_MIN,
common.fixturesDir + '/clustered-server/app.js' common.fixturesDir + '/clustered-server/app.js'
]; ];
var child = spawn(process.execPath, args); const child = spawn(process.execPath, args);
var outputLines = []; child.stderr.setEncoding('utf8');
child.stderr.on('data', function(data) { let stderr = '';
var lines = data.toString().replace(/\r/g, '').trim().split('\n'); child.stderr.on('data', data => {
var line = lines[0]; stderr += data;
if (child.killed !== true && stderr.includes('all workers are running'))
lines.forEach(function(ln) { console.log('> ' + ln); } ); child.kill();
if (line === 'all workers are running') {
assertOutputLines();
process.exit();
} else {
outputLines = outputLines.concat(lines);
}
}); });
process.on('exit', function onExit() { process.on('exit', () => {
child.kill(); for (let port = PORT_MIN; port <= PORT_MAX; port += 1)
}); assert(stderr.includes(`Debugger listening on port ${port}`));
var assertOutputLines = common.mustCall(function() {
var expectedLines = [
'Debugger listening on port ' + port,
'Debugger listening on port ' + (port + 1),
'Debugger listening on port ' + (port + 2),
];
// Do not assume any particular order of output messages,
// since workers can take different amout of time to
// start up
outputLines.sort();
assert.equal(outputLines.length, expectedLines.length);
for (var i = 0; i < expectedLines.length; i++)
assert.equal(outputLines[i], expectedLines[i]);
}); });