1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix flaky test-http-regr-gh-2928

Browse Source 
Fix flaky test-http-regr-gh-2928 that has been failing on Raspberry Pi
devices in CI.

Fixes: https://github.com/nodejs/node/issues/4830
PR-URL: https://github.com/nodejs/node/pull/5154
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This commit is contained in:
Rich Trott 2016-02-08 21:26:10 -08:00
parent 24667eeff8
commit 2848f84332
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/sequential/sequential.status
View File

@ -10,7 +10,6 @@ prefix sequential
[$system==linux] [$system==linux]
test-vm-syntax-error-stderr : PASS,FLAKY test-vm-syntax-error-stderr : PASS,FLAKY
test-http-regr-gh-2928 : PASS,FLAKY
[$system==macos] [$system==macos]

11
test/sequential/test-http-regr-gh-2928.js
View File

@ -1,3 +1,6 @@
// This test is designed to fail with a segmentation fault in Node.js 4.1.0 and
// execute without issues in Node.js 4.1.1 and up.
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
const assert = require('assert'); const assert = require('assert');
@ -5,8 +8,7 @@ const httpCommon = require('_http_common');
const HTTPParser = process.binding('http_parser').HTTPParser; const HTTPParser = process.binding('http_parser').HTTPParser;
const net = require('net'); const net = require('net');
const PARALLEL = 30; const COUNT = httpCommon.parsers.max + 1;
const COUNT = httpCommon.parsers.max + 100;
const parsers = new Array(COUNT); const parsers = new Array(COUNT);
for (var i = 0; i < parsers.length; i++) for (var i = 0; i < parsers.length; i++)
@ -41,10 +43,7 @@ var server = net.createServer(function(c) {
c.end('HTTP/1.1 200 OK\r\n\r\n', function() { c.end('HTTP/1.1 200 OK\r\n\r\n', function() {
c.destroySoon(); c.destroySoon();
}); });
}).listen(common.PORT, function() { }).listen(common.PORT, execAndClose);
for (var i = 0; i < PARALLEL; i++)
execAndClose();
});
process.on('exit', function() { process.on('exit', function() {
assert.equal(gotResponses, COUNT); assert.equal(gotResponses, COUNT);