1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: simplify first-time contributors section of Collaborator Guide

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/24387
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This commit is contained in:
Rich Trott 2018-11-15 16:47:44 -08:00
parent efa5bf9cf6
commit 282c5cfc27
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
COLLABORATOR_GUIDE.md
View File

@ -50,16 +50,14 @@ request. See [Who to CC in the issue tracker](#who-to-cc-in-the-issue-tracker).
### Welcoming First-Time Contributors ### Welcoming First-Time Contributors
Courtesy should always be shown to individuals submitting issues and pull Always show courtesy to individuals submitting issues and pull requests. Be
requests to the Node.js project. Be welcoming to first-time contributors, welcoming to first-time contributors, identified by the GitHub
identified by the GitHub ![First-time contributor](./doc/first_timer_badge.png) ![First-time contributor](./doc/first_timer_badge.png) badge.
badge.
For first-time contributors, check if the commit author is the same as the For first-time contributors, check if the commit author is the same as the pull
pull request author, and ask if they have configured their git request author. This way, once their pull request lands, GitHub will show them
as a _Contributor_. Ask if they have configured their git
[username][git-username] and [email][git-email] to their liking. [username][git-username] and [email][git-email] to their liking.
This is to make sure they would be promoted to "contributor" once their
pull request lands.
### Closing Issues and Pull Requests ### Closing Issues and Pull Requests