1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test, util: refactor isObject in test-util

Browse Source 
refactor the test for isObject function including falsy values,
the use of strictEquals and the format actual, expected

PR-URL: https://github.com/nodejs/node/pull/28878
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Alex Ramirez 2019-07-27 14:02:30 -05:00 committed by Rich Trott
parent 98d8ed64ff
commit 2713f78986
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/parallel/test-util.js
View File

@ -73,7 +73,11 @@ assert.strictEqual(util.isError([]), false);
assert.strictEqual(util.isError(Object.create(Error.prototype)), true);
// isObject
assert.ok(util.isObject({}) === true);
assert.strictEqual(util.isObject({}), true);
assert.strictEqual(util.isObject([]), true);
assert.strictEqual(util.isObject(new Number(3)), true);
assert.strictEqual(util.isObject(Number(4)), false);
assert.strictEqual(util.isObject(1), false);
// isPrimitive
assert.strictEqual(util.isPrimitive({}), false);