1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: split independent tests into separate files

Browse Source 
Move ENOENT related tests out of general fs.watch() test file and into
its own file. This may help diagnose
https://github.com/nodejs/node/issues/3541.

PR-URL: https://github.com/nodejs/node/pull/3548
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This commit is contained in:
Rich Trott 2015-10-27 09:40:41 -07:00
parent d394e9e6bb
commit 26e47efbca
2 changed files with 21 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
test/parallel/test-fs-watch-enoent.js Normal file
View File

@ -0,0 +1,21 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const fs = require('fs');
assert.throws(function() {
fs.watch('non-existent-file');
}, function(err) {
assert(err);
assert(/non-existent-file/.test(err));
assert.equal(err.filename, 'non-existent-file');
return true;
});
const watcher = fs.watch(__filename);
watcher.on('error', common.mustCall(function(err) {
assert(err);
assert(/non-existent-file/.test(err));
assert.equal(err.filename, 'non-existent-file');
}));
watcher._handle.onchange(-1, 'ENOENT', 'non-existent-file');

17
test/sequential/test-fs-watch.js
View File

@ -126,20 +126,3 @@ assert.throws(function() {
w.stop(); w.stop();
}, TypeError); }, TypeError);
oldhandle.stop(); // clean up oldhandle.stop(); // clean up
assert.throws(function() {
fs.watch('non-existent-file');
}, function(err) {
assert(err);
assert(/non-existent-file/.test(err));
assert.equal(err.filename, 'non-existent-file');
return true;
});
var watcher = fs.watch(__filename);
watcher.on('error', common.mustCall(function(err) {
assert(err);
assert(/non-existent-file/.test(err));
assert.equal(err.filename, 'non-existent-file');
}));
watcher._handle.onchange(-1, 'ENOENT', 'non-existent-file');