1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix arguments order in assert.strictEqual

Browse Source 
In the test test/parallel/test-http-client-upload.js test the
actual and expected arguments in assert.strictEqual() calls
were in the wrong order. Switched them around so the returned
value by the function is the first argument and the literal
value is the second argument.

PR-URL: https://github.com/nodejs/node/pull/24143
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
szabolcsit 2018-11-06 15:33:38 +01:00 committed by Gireesh Punathil
parent 3b4159c8ed
commit 2672582043
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/parallel/test-http-client-upload.js
View File

@ -25,7 +25,7 @@ const assert = require('assert');
const http = require('http');
const server = http.createServer(common.mustCall(function(req, res) {
assert.strictEqual('POST', req.method);
assert.strictEqual(req.method, 'POST');
req.setEncoding('utf8');
let sent_body = '';
@ -36,7 +36,7 @@ const server = http.createServer(common.mustCall(function(req, res) {
});
req.on('end', common.mustCall(function() {
assert.strictEqual('1\n2\n3\n', sent_body);
assert.strictEqual(sent_body, '1\n2\n3\n');
console.log('request complete from server');
res.writeHead(200, { 'Content-Type': 'text/plain' });
res.write('hello\n');