1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix pummel test failures

Browse Source 
A handful of tests in `test/pummel` were failing due to undefined
variables.

The tests in pummel are not run in CI or otherwise exercised regularly
so these failures can go unnoticed for a long time.

PR-URL: https://github.com/nodejs/node/pull/6012
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This commit is contained in:
Rich Trott 2016-04-01 21:40:21 -07:00
parent c60faf6ba8
commit 263222da49
3 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/pummel/test-crypto-dh.js
View File

@ -1,6 +1,7 @@
'use strict'; 'use strict';
var common = require('../common'); const common = require('../common');
var assert = require('assert'); const assert = require('assert');
const crypto = require('crypto');
if (!common.hasCrypto) { if (!common.hasCrypto) {
console.log('1..0 # Skipped: node compiled without OpenSSL.'); console.log('1..0 # Skipped: node compiled without OpenSSL.');

2
test/pummel/test-dtrace-jsstack.js
View File

@ -14,7 +14,7 @@ if (os.type() != 'SunOS') {
var frames = [ 'stalloogle', 'bagnoogle', 'doogle' ]; var frames = [ 'stalloogle', 'bagnoogle', 'doogle' ];
var stalloogle = function(str) { var stalloogle = function(str) {
expected = str; global.expected = str;
os.loadavg(); os.loadavg();
}; };

12
test/pummel/test-net-throttle.js
View File

@ -1,15 +1,15 @@
'use strict'; 'use strict';
var common = require('../common'); const common = require('../common');
var assert = require('assert'); const assert = require('assert');
var net = require('net'); const net = require('net');
var N = 1024 * 1024; const N = 1024 * 1024;
var part_N = N / 3; const part_N = N / 3;
var chars_recved = 0; var chars_recved = 0;
var npauses = 0; var npauses = 0;
console.log('build big string'); console.log('build big string');
body = 'C'.repeat(N); const body = 'C'.repeat(N);
console.log('start server on port ' + common.PORT); console.log('start server on port ' + common.PORT);