1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve internal/buffer.js test coverage

Browse Source 
Added tests buffer.js methods to write 48 bit value to
improve test coverage.

PR-URL: https://github.com/nodejs/node/pull/21061
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
This commit is contained in:
Masashi Hirano 2018-05-30 00:57:18 +09:00 committed by Lance Ball
parent 42adb65d2f
commit 262f3777ce
No known key found for this signature in database
GPG Key ID: 1B4326AE55E9408C
4 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-buffer-readint.js
View File

@ -160,7 +160,7 @@ const assert = require('assert');
}); });
// Test 1 to 6 bytes. // Test 1 to 6 bytes.
for (let i = 1; i < 6; i++) { for (let i = 1; i <= 6; i++) {
['readIntBE', 'readIntLE'].forEach((fn) => { ['readIntBE', 'readIntLE'].forEach((fn) => {
['', '0', null, {}, [], () => {}, true, false, undefined].forEach((o) => { ['', '0', null, {}, [], () => {}, true, false, undefined].forEach((o) => {
assert.throws( assert.throws(

2
test/parallel/test-buffer-readuint.js
View File

@ -128,7 +128,7 @@ const assert = require('assert');
}); });
// Test 1 to 6 bytes. // Test 1 to 6 bytes.
for (let i = 1; i < 6; i++) { for (let i = 1; i <= 6; i++) {
['readUIntBE', 'readUIntLE'].forEach((fn) => { ['readUIntBE', 'readUIntLE'].forEach((fn) => {
['', '0', null, {}, [], () => {}, true, false, undefined].forEach((o) => { ['', '0', null, {}, [], () => {}, true, false, undefined].forEach((o) => {
assert.throws( assert.throws(

15
test/parallel/test-buffer-writeint.js
View File

@ -162,6 +162,21 @@ const errorOutOfBounds = common.expectsError({
}); });
} }
// Test 48 bit
{
const value = 0x1234567890ab;
const buffer = Buffer.allocUnsafe(6);
buffer.writeIntBE(value, 0, 6);
assert.ok(buffer.equals(new Uint8Array([
0x12, 0x34, 0x56, 0x78, 0x90, 0xab
])));
buffer.writeIntLE(value, 0, 6);
assert.ok(buffer.equals(new Uint8Array([
0xab, 0x90, 0x78, 0x56, 0x34, 0x12
])));
}
// Test Int // Test Int
{ {
const data = Buffer.alloc(8); const data = Buffer.alloc(8);

11
test/parallel/test-buffer-writeuint.js
View File

@ -110,6 +110,17 @@ const assert = require('assert');
assert.ok(data.equals(new Uint8Array([0x6d, 0x6d, 0x6d, 0x0a, 0xf9, 0xe7]))); assert.ok(data.equals(new Uint8Array([0x6d, 0x6d, 0x6d, 0x0a, 0xf9, 0xe7])));
} }
// Test 48 bit
{
const value = 0x1234567890ab;
const data = Buffer.allocUnsafe(6);
data.writeUIntBE(value, 0, 6);
assert.ok(data.equals(new Uint8Array([0x12, 0x34, 0x56, 0x78, 0x90, 0xab])));
data.writeUIntLE(value, 0, 6);
assert.ok(data.equals(new Uint8Array([0xab, 0x90, 0x78, 0x56, 0x34, 0x12])));
}
// Test UInt // Test UInt
{ {
const data = Buffer.alloc(8); const data = Buffer.alloc(8);