1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: add override to ServerDone function

Browse Source 
Currently the following compiler warning is displayed when building:

  ../test/cctest/test_inspector_socket_server.cc:142:8: warning:
  'ServerDone' overrides a member function but is not marked 'override'
        [-Winconsistent-missing-override]
    void ServerDone() {
         ^
  ../src/inspector_socket_server.h:30:16: note: overridden virtual
  function is here
    virtual void ServerDone() = 0;
                 ^

This commit marks ServerDone with override to get rid of the warning.

PR-URL: https://github.com/nodejs/node/pull/13166
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
This commit is contained in:
Daniel Bevenius 2017-05-23 08:28:13 +02:00 committed by Anna Henningsen
parent 155687cb7e
commit 25ade76fb0
No known key found for this signature in database
GPG Key ID: D8B9F5AEAE84E4CF
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/cctest/test_inspector_socket_server.cc
View File

@ -139,7 +139,7 @@ class TestInspectorServerDelegate : public SocketServerDelegate {
server_->Send(session_id_, message); server_->Send(session_id_, message);
} }
void ServerDone() { void ServerDone() override {
done = true; done = true;
} }