1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix order of arguments passed to strictEqual

Browse Source 
The argument order in the strictEqual check was in the wrong order.
The first argument is now the actual value and the second argument is
the expected value.

PR-URL: https://github.com/nodejs/node/pull/23571
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
Joe Shindelar 2018-10-12 11:03:15 -07:00 committed by Ruben Bridgewater
parent cac4909bf3
commit 2505f05ce8
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/parallel/test-net-socket-local-address.js
View File

@ -18,8 +18,8 @@ const server = net.createServer((socket) => {
server.on('close', common.mustCall(() => {
// client and server should agree on the ports used
assert.deepStrictEqual(clientLocalPorts, serverRemotePorts);
assert.strictEqual(2, conns);
assert.deepStrictEqual(serverRemotePorts, clientLocalPorts);
assert.strictEqual(conns, 2);
}));
server.listen(0, common.localhostIPv4, connect);