1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: organize TLSWrap declarations by parent

Browse Source 
Make it clear which of the multiple interfaces a TLSWrap method is
implementing by grouping and commenting the related methods.

PR-URL: https://github.com/nodejs/node/pull/25861
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Sam Roberts 2019-01-31 13:51:20 -08:00
parent 73b204cd2b
commit 24ea4a3452
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/tls_wrap.h
View File

@ -57,16 +57,19 @@ class TLSWrap : public AsyncWrap,
v8::Local<v8::Context> context, v8::Local<v8::Context> context,
void* priv); void* priv);
int GetFD() override; // Implement StreamBase:
bool IsAlive() override; bool IsAlive() override;
bool IsClosing() override; bool IsClosing() override;
bool IsIPCPipe() override;
// JavaScript functions int GetFD() override;
int ReadStart() override;
int ReadStop() override;
ShutdownWrap* CreateShutdownWrap( ShutdownWrap* CreateShutdownWrap(
v8::Local<v8::Object> req_wrap_object) override; v8::Local<v8::Object> req_wrap_object) override;
AsyncWrap* GetAsyncWrap() override;
// Implement StreamResource:
int ReadStart() override; // Exposed to JS
int ReadStop() override; // Exposed to JS
int DoShutdown(ShutdownWrap* req_wrap) override; int DoShutdown(ShutdownWrap* req_wrap) override;
int DoWrite(WriteWrap* w, int DoWrite(WriteWrap* w,
uv_buf_t* bufs, uv_buf_t* bufs,
@ -79,8 +82,8 @@ class TLSWrap : public AsyncWrap,
void NewSessionDoneCb(); void NewSessionDoneCb();
// Implement MemoryRetainer:
void MemoryInfo(MemoryTracker* tracker) const override; void MemoryInfo(MemoryTracker* tracker) const override;
SET_MEMORY_INFO_NAME(TLSWrap) SET_MEMORY_INFO_NAME(TLSWrap)
SET_SELF_SIZE(TLSWrap) SET_SELF_SIZE(TLSWrap)
@ -136,13 +139,11 @@ class TLSWrap : public AsyncWrap,
} }
} }
AsyncWrap* GetAsyncWrap() override; // Implement StreamListener:
bool IsIPCPipe() override; // Returns buf that points into enc_in_.
// Resource implementation
void OnStreamAfterWrite(WriteWrap* w, int status) override;
uv_buf_t OnStreamAlloc(size_t size) override; uv_buf_t OnStreamAlloc(size_t size) override;
void OnStreamRead(ssize_t nread, const uv_buf_t& buf) override; void OnStreamRead(ssize_t nread, const uv_buf_t& buf) override;
void OnStreamAfterWrite(WriteWrap* w, int status) override;
v8::Local<v8::Value> GetSSLError(int status, int* err, std::string* msg); v8::Local<v8::Value> GetSSLError(int status, int* err, std::string* msg);