1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: remove StreamResourc::Cast()

Browse Source 
This is not necessary since C++ already has `static_cast`
as a proper way to cast inside a class hierarchy.

PR-URL: https://github.com/nodejs/node/pull/17564
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Anna Henningsen 2017-12-09 04:40:20 +01:00
parent 486290b1fe
commit 24b0f67c2b
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
8 changed files with 2 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/js_stream.cc
View File

@ -74,11 +74,6 @@ void JSStream::OnReadImpl(ssize_t nread,
}
void* JSStream::Cast() {
return static_cast<void*>(this);
}
AsyncWrap* JSStream::GetAsyncWrap() {
return static_cast<AsyncWrap*>(this);
}

1
src/js_stream.h
View File

@ -18,7 +18,6 @@ class JSStream : public AsyncWrap, public StreamBase {
~JSStream();
void* Cast() override;
bool IsAlive() override;
bool IsClosing() override;
int ReadStart() override;

3
src/node_http2.h
View File

@ -672,8 +672,7 @@ class Http2Stream : public AsyncWrap,
return false;
}
AsyncWrap* GetAsyncWrap() override { return static_cast<AsyncWrap*>(this); }
void* Cast() override { return reinterpret_cast<void*>(this); }
AsyncWrap* GetAsyncWrap() override { return this; }
int DoWrite(WriteWrap* w, uv_buf_t* bufs, size_t count,
uv_stream_t* send_handle) override;

4
src/stream_base.h
View File

@ -231,7 +231,6 @@ class StreamBase : public StreamResource {
v8::Local<v8::FunctionTemplate> target,
int flags = kFlagNone);
virtual void* Cast() = 0;
virtual bool IsAlive() = 0;
virtual bool IsClosing() = 0;
virtual bool IsIPCPipe();
@ -250,9 +249,6 @@ class StreamBase : public StreamResource {
consumed_ = false;
}
template <class Outer>
inline Outer* Cast() { return static_cast<Outer*>(Cast()); }
void EmitData(ssize_t nread,
v8::Local<v8::Object> buf,
v8::Local<v8::Object> handle);

5
src/stream_wrap.cc
View File

@ -126,11 +126,6 @@ bool LibuvStreamWrap::IsClosing() {
}
void* LibuvStreamWrap::Cast() {
return reinterpret_cast<void*>(this);
}
AsyncWrap* LibuvStreamWrap::GetAsyncWrap() {
return static_cast<AsyncWrap*>(this);
}

1
src/stream_wrap.h
View File

@ -40,7 +40,6 @@ class LibuvStreamWrap : public HandleWrap, public StreamBase {
v8::Local<v8::Context> context);
int GetFD() override;
void* Cast() override;
bool IsAlive() override;
bool IsClosing() override;
bool IsIPCPipe() override;

7
src/tls_wrap.cc
View File

@ -347,7 +347,7 @@ void TLSWrap::EncOut() {
void TLSWrap::EncOutCb(WriteWrap* req_wrap, int status) {
TLSWrap* wrap = req_wrap->wrap()->Cast<TLSWrap>();
TLSWrap* wrap = static_cast<TLSWrap*>(req_wrap->wrap());
req_wrap->Dispose();
// We should not be getting here after `DestroySSL`, because all queued writes
@ -534,11 +534,6 @@ bool TLSWrap::ClearIn() {
}
void* TLSWrap::Cast() {
return reinterpret_cast<void*>(this);
}
AsyncWrap* TLSWrap::GetAsyncWrap() {
return static_cast<AsyncWrap*>(this);
}

1
src/tls_wrap.h
View File

@ -56,7 +56,6 @@ class TLSWrap : public AsyncWrap,
v8::Local<v8::Value> unused,
v8::Local<v8::Context> context);
void* Cast() override;
int GetFD() override;
bool IsAlive() override;
bool IsClosing() override;