1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: add squash guideline to pull-requests doc

Browse Source 
Tell the contributor to generally not squash commits during the pull
request review process.

PR-URL: https://github.com/nodejs/node/pull/20413
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2018-04-30 06:43:15 -07:00
parent ac6d1f20b9
commit 24a5ac797d
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
doc/guides/contributing/pull-requests.md
View File

@ -599,9 +599,10 @@ whether the failure was caused by the changes in the Pull Request.
### Commit Squashing ### Commit Squashing
When the commits in your Pull Request land, they may be squashed In most cases, do not squash commits that you add to your Pull Request during
into one commit per logical change. Metadata will be added to the commit the review process. When the commits in your Pull Request land, they may be
message (including links to the Pull Request, links to relevant issues, squashed into one commit per logical change. Metadata will be added to the
commit message (including links to the Pull Request, links to relevant issues,
and the names of the reviewers). The commit history of your Pull Request, and the names of the reviewers). The commit history of your Pull Request,
however, will stay intact on the Pull Request page. however, will stay intact on the Pull Request page.