1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix flaky test-inspector

Browse Source 
Using `socket.destroy()` instead of `socket.end()` fixes
more-than-intermittent ECONNRESET issues on Windows.

PR-URL: https://github.com/nodejs/node/pull/9727
Fixes: https://github.com/nodejs/node/issues/8804
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
This commit is contained in:
Rich Trott 2016-11-21 13:13:58 -08:00
parent fd644f51f8
commit 2486273c0e
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/inspector/inspector-helper.js
View File

@ -286,7 +286,7 @@ TestSession.prototype.disconnect = function(childDone) {
this.expectClose_ = true; this.expectClose_ = true;
this.harness_.childInstanceDone = this.harness_.childInstanceDone =
this.harness_.childInstanceDone || childDone; this.harness_.childInstanceDone || childDone;
this.socket_.end(); this.socket_.destroy();
console.log('[test]', 'Connection terminated'); console.log('[test]', 'Connection terminated');
callback(); callback();
}); });

1
test/inspector/inspector.status
View File

@ -7,4 +7,3 @@ prefix inspector
[true] # This section applies to all platforms [true] # This section applies to all platforms
[$system==win32] [$system==win32]
test-inspector : PASS,FLAKY