1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: use default initializers over settings fields on the constructor

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/23532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Andrew J D McCann 2018-10-12 10:31:06 -07:00 committed by Ruben Bridgewater
parent c3ebc028d2
commit 244180826e
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/spawn_sync.cc
View File

@ -50,9 +50,7 @@ using v8::String;
using v8::Value;
SyncProcessOutputBuffer::SyncProcessOutputBuffer()
: used_(0),
next_(nullptr) {
SyncProcessOutputBuffer::SyncProcessOutputBuffer() {
}

4
src/spawn_sync.h
View File

@ -56,9 +56,9 @@ class SyncProcessOutputBuffer {
private:
// Use unsigned int because that's what `uv_buf_init` takes.
mutable char data_[kBufferSize];
unsigned int used_;
unsigned int used_ = 0;
SyncProcessOutputBuffer* next_;
SyncProcessOutputBuffer* next_ = nullptr;
};