1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix test.py command line options processing

Browse Source 
https://github.com/nodejs/node/pull/11086 had introduced a regression
that broke command line options processing for tools/test.py.

Basically, it made tools/test.py discard the command line argument that
would be passed after `--abort-on-timeout`. For instance, when running:

```
$ python tools/test.py --abort-on-timeout path/to/some-test
```

all tests would be run because the last command line argument
(`/path/to/some-test`) would be discarded.

This change fixes this regression.

Refs: https://github.com/nodejs/node/pull/11086
PR-URL: https://github.com/nodejs/node/pull/11153
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Julien Gilli 2017-02-03 19:57:25 +00:00 committed by Anna Henningsen
parent 5e52a9ac09
commit 23cda7d9de
No known key found for this signature in database
GPG Key ID: D8B9F5AEAE84E4CF
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/test.py
View File

@ -1399,7 +1399,7 @@ def BuildOptions():
default=1, type="int") default=1, type="int")
result.add_option('--abort-on-timeout', result.add_option('--abort-on-timeout',
help='Send SIGABRT instead of SIGTERM to kill processes that time out', help='Send SIGABRT instead of SIGTERM to kill processes that time out',
default=False, dest="abort_on_timeout") default=False, action="store_true", dest="abort_on_timeout")
return result return result