1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix parameter order of assertions

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/23565
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This commit is contained in:
Pete Lombardo 2018-10-12 14:02:44 -04:00 committed by Ruben Bridgewater
parent 8a32a51881
commit 22afe4fafc
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/pummel/test-net-throttle.js
View File

@ -37,7 +37,7 @@ console.log(`start server on port ${common.PORT}`);
const server = net.createServer(function(connection) { const server = net.createServer(function(connection) {
connection.write(body.slice(0, part_N)); connection.write(body.slice(0, part_N));
connection.write(body.slice(part_N, 2 * part_N)); connection.write(body.slice(part_N, 2 * part_N));
assert.strictEqual(false, connection.write(body.slice(2 * part_N, N))); assert.strictEqual(connection.write(body.slice(2 * part_N, N)), false);
console.log(`bufferSize: ${connection.bufferSize}`, 'expecting', N); console.log(`bufferSize: ${connection.bufferSize}`, 'expecting', N);
assert.ok(connection.bufferSize >= 0 && assert.ok(connection.bufferSize >= 0 &&
connection.writableLength <= N); connection.writableLength <= N);
@ -58,7 +58,7 @@ server.listen(common.PORT, function() {
console.log('pause'); console.log('pause');
const x = chars_recved; const x = chars_recved;
setTimeout(function() { setTimeout(function() {
assert.strictEqual(chars_recved, x); assert.strictEqual(x, chars_recved);
client.resume(); client.resume();
console.log('resume'); console.log('resume');
paused = false; paused = false;
@ -74,6 +74,6 @@ server.listen(common.PORT, function() {
process.on('exit', function() { process.on('exit', function() {
assert.strictEqual(N, chars_recved); assert.strictEqual(chars_recved, N);
assert.strictEqual(true, npauses > 2); assert.strictEqual(npauses > 2, true);
}); });