1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

inspector: add missing virtual destructor

Browse Source 
This fixes a resource leak detected by a Coverity scan.

PR-URL: https://github.com/nodejs/node/pull/13198
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
This commit is contained in:
Eugene Ostroukhov 2017-05-24 10:04:39 -07:00 committed by Anna Henningsen
parent e2f2d18032
commit 21c0c0275a
No known key found for this signature in database
GPG Key ID: D8B9F5AEAE84E4CF
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/inspector_agent.cc
View File

@ -195,7 +195,7 @@ class JsBindingsSessionDelegate : public InspectorSessionDelegate {
v8::WeakCallbackType::kParameter); v8::WeakCallbackType::kParameter);
} }
virtual ~JsBindingsSessionDelegate() { ~JsBindingsSessionDelegate() override {
session_.Reset(); session_.Reset();
receiver_.Reset(); receiver_.Reset();
callback_.Reset(); callback_.Reset();

1
src/inspector_agent.h
View File

@ -37,6 +37,7 @@ namespace inspector {
class InspectorSessionDelegate { class InspectorSessionDelegate {
public: public:
virtual ~InspectorSessionDelegate() = default;
virtual bool WaitForFrontendMessage() = 0; virtual bool WaitForFrontendMessage() = 0;
virtual void OnMessage(const v8_inspector::StringView& message) = 0; virtual void OnMessage(const v8_inspector::StringView& message) = 0;
}; };