1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: move debug statement

Browse Source 
This will allow `localAddress` to be properly set before writing
debug output.

PR-URL: https://github.com/nodejs/node/pull/12616
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Brian White 2017-04-24 02:27:14 -04:00 committed by Ruben Bridgewater
parent 6db825ae82
commit 2154a3ce0f
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/net.js
View File

@ -887,9 +887,6 @@ function internalConnect(
var err; var err;
if (localAddress || localPort) { if (localAddress || localPort) {
debug('binding to localAddress: %s and localPort: %d (addressType: %d)',
localAddress, localPort, addressType);
if (addressType === 4) { if (addressType === 4) {
localAddress = localAddress || '0.0.0.0'; localAddress = localAddress || '0.0.0.0';
err = self._handle.bind(localAddress, localPort); err = self._handle.bind(localAddress, localPort);
@ -900,6 +897,8 @@ function internalConnect(
self.destroy(new TypeError('Invalid addressType: ' + addressType)); self.destroy(new TypeError('Invalid addressType: ' + addressType));
return; return;
} }
debug('binding to localAddress: %s and localPort: %d (addressType: %d)',
localAddress, localPort, addressType);
if (err) { if (err) {
const ex = exceptionWithHostPort(err, 'bind', localAddress, localPort); const ex = exceptionWithHostPort(err, 'bind', localAddress, localPort);