1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

errors: alter ERR_INVALID_IP_ADDRESS

Browse Source 
changes the base instance for ERR_INVALID_IP_ADDRESS
from Error to TypeError as a more accurate representation
of the error.

PR-URL: https://github.com/nodejs/node/pull/19979
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
davidmarkclements 2018-04-12 18:48:03 +02:00 committed by James M Snell
parent 985d180855
commit 2119ceedbf
3 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/dns.js
View File

@ -316,7 +316,7 @@ function setServers(servers) {
return newSet.push([ipVersion, s, parseInt(p)]); return newSet.push([ipVersion, s, parseInt(p)]);
} }
throw new ERR_INVALID_IP_ADDRESS.Error(serv); throw new ERR_INVALID_IP_ADDRESS(serv);
}); });
const errorNumber = this._handle.setServers(newSet); const errorNumber = this._handle.setServers(newSet);

3
lib/internal/errors.js
View File

@ -891,8 +891,7 @@ E('ERR_INVALID_FILE_URL_HOST',
E('ERR_INVALID_FILE_URL_PATH', 'File URL path %s', TypeError); E('ERR_INVALID_FILE_URL_PATH', 'File URL path %s', TypeError);
E('ERR_INVALID_HANDLE_TYPE', 'This handle type cannot be sent', TypeError); E('ERR_INVALID_HANDLE_TYPE', 'This handle type cannot be sent', TypeError);
E('ERR_INVALID_HTTP_TOKEN', '%s must be a valid HTTP token ["%s"]', TypeError); E('ERR_INVALID_HTTP_TOKEN', '%s must be a valid HTTP token ["%s"]', TypeError);
// The `Error` should probably be a `TypeError`. E('ERR_INVALID_IP_ADDRESS', 'Invalid IP address: %s', TypeError);
E('ERR_INVALID_IP_ADDRESS', 'Invalid IP address: %s', TypeError, Error);
E('ERR_INVALID_OPT_VALUE', (name, value) => E('ERR_INVALID_OPT_VALUE', (name, value) =>
`The value "${String(value)}" is invalid for option "${name}"`, `The value "${String(value)}" is invalid for option "${name}"`,
TypeError, TypeError,

4
test/parallel/test-dns.js
View File

@ -70,12 +70,12 @@ dns.setServers(goog);
assert.deepStrictEqual(dns.getServers(), goog); assert.deepStrictEqual(dns.getServers(), goog);
common.expectsError(() => dns.setServers(['foobar']), { common.expectsError(() => dns.setServers(['foobar']), {
code: 'ERR_INVALID_IP_ADDRESS', code: 'ERR_INVALID_IP_ADDRESS',
type: Error, type: TypeError,
message: 'Invalid IP address: foobar' message: 'Invalid IP address: foobar'
}); });
common.expectsError(() => dns.setServers(['127.0.0.1:va']), { common.expectsError(() => dns.setServers(['127.0.0.1:va']), {
code: 'ERR_INVALID_IP_ADDRESS', code: 'ERR_INVALID_IP_ADDRESS',
type: Error, type: TypeError,
message: 'Invalid IP address: 127.0.0.1:va' message: 'Invalid IP address: 127.0.0.1:va'
}); });
assert.deepStrictEqual(dns.getServers(), goog); assert.deepStrictEqual(dns.getServers(), goog);