1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fs: make fs.promises non-enumerable

Browse Source 
This prevents the experimental feature warning from being emitted
in cases where fs.promises is not actually used.

PR-URL: https://github.com/nodejs/node/pull/20632
Fixes: https://github.com/nodejs/node/issues/20504
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This commit is contained in:
cjihrig 2018-05-09 12:36:59 -04:00
parent 6fd8022641
commit 20509ebee6
No known key found for this signature in database
GPG Key ID: 7434390BDBE9B9C5
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/fs.js
View File

@ -79,7 +79,7 @@ let warn = true;
Object.defineProperty(fs, 'promises', { Object.defineProperty(fs, 'promises', {
configurable: true, configurable: true,
enumerable: true, enumerable: false,
get() { get() {
if (warn) { if (warn) {
warn = false; warn = false;

7
test/parallel/test-fs-promises.js
View File

@ -5,7 +5,8 @@ const assert = require('assert');
const tmpdir = require('../common/tmpdir'); const tmpdir = require('../common/tmpdir');
const fixtures = require('../common/fixtures'); const fixtures = require('../common/fixtures');
const path = require('path'); const path = require('path');
const fsPromises = require('fs').promises; const fs = require('fs');
const fsPromises = fs.promises;
const { const {
access, access,
chmod, chmod,
@ -38,6 +39,10 @@ const tmpDir = tmpdir.path;
common.crashOnUnhandledRejection(); common.crashOnUnhandledRejection();
// fs.promises should not be enumerable as long as it causes a warning to be
// emitted.
assert.strictEqual(Object.keys(fs).includes('promises'), false);
{ {
access(__filename, 'r') access(__filename, 'r')
.then(common.mustCall()) .then(common.mustCall())