1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cluster: remove deprecated property

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/13702
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
James M Snell 2017-06-15 08:31:11 -07:00
parent eaaec57332
commit 1fcb76e8f2
2 changed files with 0 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
doc/api/cluster.md
View File

@ -451,40 +451,6 @@ if (cluster.isMaster) {
} }
``` ```
### worker.suicide
<!-- YAML
added: v0.7.0
deprecated: v6.0.0
changes:
- version: v7.0.0
pr-url: https://github.com/nodejs/node/pull/3747
description: Accessing this property will now emit a deprecation warning.
-->
> Stability: 0 - Deprecated: Use [`worker.exitedAfterDisconnect`][] instead.
An alias to [`worker.exitedAfterDisconnect`][].
Set by calling `.kill()` or `.disconnect()`. Until then, it is `undefined`.
The boolean `worker.suicide` is used to distinguish between voluntary
and accidental exit, the master may choose not to respawn a worker based on
this value.
```js
cluster.on('exit', (worker, code, signal) => {
if (worker.suicide === true) {
console.log('Oh, it was just voluntary – no need to worry');
}
});
// kill worker
worker.kill();
```
This API only exists for backwards compatibility and will be removed in the
future.
## Event: 'disconnect' ## Event: 'disconnect'
<!-- YAML <!-- YAML
added: v0.7.9 added: v0.7.9

14
lib/internal/cluster/worker.js
View File

@ -1,10 +1,6 @@
'use strict'; 'use strict';
const EventEmitter = require('events'); const EventEmitter = require('events');
const internalUtil = require('internal/util');
const util = require('util'); const util = require('util');
const defineProperty = Object.defineProperty;
const suicideDeprecationMessage =
'worker.suicide is deprecated. Please use worker.exitedAfterDisconnect.';
module.exports = Worker; module.exports = Worker;
@ -20,16 +16,6 @@ function Worker(options) {
this.exitedAfterDisconnect = undefined; this.exitedAfterDisconnect = undefined;
defineProperty(this, 'suicide', {
get: internalUtil.deprecate(
() => this.exitedAfterDisconnect,
suicideDeprecationMessage, 'DEP0007'),
set: internalUtil.deprecate(
(val) => { this.exitedAfterDisconnect = val; },
suicideDeprecationMessage, 'DEP0007'),
enumerable: true
});
this.state = options.state || 'none'; this.state = options.state || 'none';
this.id = options.id | 0; this.id = options.id | 0;