1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor the code in test-http-keep-alive

Browse Source 
* use common.mustCall to control the functions execution automatically
* use let and const instead of var
* use assert.strictEqual instead assert.equal

PR-URL: https://github.com/nodejs/node/pull/10350
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
This commit is contained in:
Adrian Estrada 2016-12-20 19:00:10 -05:00 committed by Italo A. Casas
parent dd9864928a
commit 1e98ea3f5e
1 changed files with 25 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
test/parallel/test-http-keep-alive.js
View File

@ -1,51 +1,51 @@
'use strict';
require('../common');
var assert = require('assert');
var http = require('http');
const common = require('../common');
const assert = require('assert');
const http = require('http');
var body = 'hello world\n';
const server = http.createServer(common.mustCall((req, res) => {
const body = 'hello world\n';
var server = http.createServer(function(req, res) {
res.writeHead(200, {'Content-Length': body.length});
res.write(body);
res.end();
});
}, 3));
var agent = new http.Agent({maxSockets: 1});
var headers = {'connection': 'keep-alive'};
var name;
const agent = new http.Agent({maxSockets: 1});
const headers = {'connection': 'keep-alive'};
let name;
server.listen(0, function() {
server.listen(0, common.mustCall(function() {
name = agent.getName({ port: this.address().port });
http.get({
path: '/', headers: headers, port: this.address().port, agent: agent
}, function(response) {
assert.equal(agent.sockets[name].length, 1);
assert.equal(agent.requests[name].length, 2);
}, common.mustCall((response) => {
assert.strictEqual(agent.sockets[name].length, 1);
assert.strictEqual(agent.requests[name].length, 2);
response.resume();
});
}));
http.get({
path: '/', headers: headers, port: this.address().port, agent: agent
}, function(response) {
assert.equal(agent.sockets[name].length, 1);
assert.equal(agent.requests[name].length, 1);
}, common.mustCall((response) => {
assert.strictEqual(agent.sockets[name].length, 1);
assert.strictEqual(agent.requests[name].length, 1);
response.resume();
});
}));
http.get({
path: '/', headers: headers, port: this.address().port, agent: agent
}, function(response) {
response.on('end', function() {
assert.equal(agent.sockets[name].length, 1);
}, common.mustCall((response) => {
response.on('end', common.mustCall(() => {
assert.strictEqual(agent.sockets[name].length, 1);
assert(!agent.requests.hasOwnProperty(name));
server.close();
});
}));
response.resume();
});
});
}));
}));
process.on('exit', function() {
process.on('exit', () => {
assert(!agent.sockets.hasOwnProperty(name));
assert(!agent.requests.hasOwnProperty(name));
});