1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: don't assume openssl s_client supports -ssl3

Browse Source 
Scan the child process's stderr for an 'unknown flag' error message and
mark the test as skipped if found.

Fixes: https://github.com/nodejs/node/issues/3927
PR-URL: https://github.com/nodejs/node/pull/4204
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Ben Noordhuis 2015-12-08 23:46:07 +01:00
parent da5cdc2207
commit 1e89830a11
1 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
test/parallel/test-tls-no-sslv3.js
View File

@ -19,6 +19,8 @@ if (common.opensslCli === false) {
var cert = fs.readFileSync(common.fixturesDir + '/test_cert.pem'); var cert = fs.readFileSync(common.fixturesDir + '/test_cert.pem');
var key = fs.readFileSync(common.fixturesDir + '/test_key.pem'); var key = fs.readFileSync(common.fixturesDir + '/test_key.pem');
var server = tls.createServer({ cert: cert, key: key }, common.fail); var server = tls.createServer({ cert: cert, key: key }, common.fail);
var errors = [];
var stderr = '';
server.listen(common.PORT, '127.0.0.1', function() { server.listen(common.PORT, '127.0.0.1', function() {
var address = this.address().address + ':' + this.address().port; var address = this.address().address + ':' + this.address().port;
@ -34,13 +36,25 @@ server.listen(common.PORT, '127.0.0.1', function() {
if (common.isWindows) if (common.isWindows)
args.push('-no_rand_screen'); args.push('-no_rand_screen');
var client = spawn(common.opensslCli, args, { stdio: 'inherit' }); var client = spawn(common.opensslCli, args, { stdio: 'pipe' });
client.stdout.pipe(process.stdout);
client.stderr.pipe(process.stderr);
client.stderr.setEncoding('utf8');
client.stderr.on('data', data => stderr += data);
client.once('exit', common.mustCall(function(exitCode) { client.once('exit', common.mustCall(function(exitCode) {
assert.equal(exitCode, 1); assert.equal(exitCode, 1);
server.close(); server.close();
})); }));
}); });
server.once('clientError', common.mustCall(function(err, conn) { server.on('clientError', err => errors.push(err));
assert(/:wrong version number/.test(err.message));
})); process.on('exit', function() {
if (/unknown option -ssl3/.test(stderr)) {
console.log('1..0 # Skipped: `openssl s_client -ssl3` not supported.');
} else {
assert.equal(errors.length, 1);
assert(/:wrong version number/.test(errors[0].message));
}
});