1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

buffer: avoid use of arguments

Browse Source 
Avoid use of arguments in Buffer.prototype.toString()

PR-URL: https://github.com/nodejs/node/pull/11358
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
James M Snell 2017-02-13 14:14:42 -08:00
parent 797ec338ea
commit 1e21d05632
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/buffer.js
View File

@ -503,12 +503,12 @@ Buffer.prototype.copy = function(target, targetStart, sourceStart, sourceEnd) {
return binding.copy(this, target, targetStart, sourceStart, sourceEnd); return binding.copy(this, target, targetStart, sourceStart, sourceEnd);
}; };
Buffer.prototype.toString = function() { Buffer.prototype.toString = function(encoding, start, end) {
let result; let result;
if (arguments.length === 0) { if (arguments.length === 0) {
result = this.utf8Slice(0, this.length); result = this.utf8Slice(0, this.length);
} else { } else {
result = slowToString.apply(this, arguments); result = slowToString.call(this, encoding, start, end);
} }
if (result === undefined) if (result === undefined)
throw new Error('"toString()" failed'); throw new Error('"toString()" failed');