1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-file-write-stream

Browse Source 
Replace all `var` occurrences in test-file-write-stream.js with
`const` (where they are not being reassigned) and `let` (where they are
being reassigned).

Add strict comparison to the asserts and if statements:

  - Replace `assert.equal` with `assert.strictEqual` where:
    1. Result of `typeof` being compared to a string literal.
    2. Result of `fs.readFileSync` with UTF-8 encoding being compared to
       a string constant.

  - Replace `==` with `===` where integer values are being compared to
    integer literals.

Remove unnecessary very IIFE.

Use template literals.

PR-URL: https://github.com/nodejs/node/pull/8894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Sudaraka Wijesinghe 2016-10-02 10:28:31 +05:30 committed by Rich Trott
parent f68e0d1864
commit 1d4ba1be1a
1 changed files with 17 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
test/parallel/test-file-write-stream.js
View File

@ -1,18 +1,18 @@
'use strict'; 'use strict';
var common = require('../common'); const common = require('../common');
var assert = require('assert'); const assert = require('assert');
var path = require('path'); const path = require('path');
var fs = require('fs'); const fs = require('fs');
var fn = path.join(common.tmpDir, 'write.txt'); const fn = path.join(common.tmpDir, 'write.txt');
common.refreshTmpDir(); common.refreshTmpDir();
var file = fs.createWriteStream(fn, { const file = fs.createWriteStream(fn, {
highWaterMark: 10 highWaterMark: 10
}); });
var EXPECTED = '012345678910'; const EXPECTED = '012345678910';
var callbacks = { const callbacks = {
open: -1, open: -1,
drain: -2, drain: -2,
close: -1 close: -1
@ -22,7 +22,7 @@ file
.on('open', function(fd) { .on('open', function(fd) {
console.error('open!'); console.error('open!');
callbacks.open++; callbacks.open++;
assert.equal('number', typeof fd); assert.strictEqual('number', typeof fd);
}) })
.on('error', function(err) { .on('error', function(err) {
throw err; throw err;
@ -30,11 +30,11 @@ file
.on('drain', function() { .on('drain', function() {
console.error('drain!', callbacks.drain); console.error('drain!', callbacks.drain);
callbacks.drain++; callbacks.drain++;
if (callbacks.drain == -1) { if (callbacks.drain === -1) {
assert.equal(EXPECTED, fs.readFileSync(fn, 'utf8')); assert.strictEqual(EXPECTED, fs.readFileSync(fn, 'utf8'));
file.write(EXPECTED); file.write(EXPECTED);
} else if (callbacks.drain == 0) { } else if (callbacks.drain === 0) {
assert.equal(EXPECTED + EXPECTED, fs.readFileSync(fn, 'utf8')); assert.strictEqual(EXPECTED + EXPECTED, fs.readFileSync(fn, 'utf8'));
file.end(); file.end();
} }
}) })
@ -51,15 +51,13 @@ file
fs.unlinkSync(fn); fs.unlinkSync(fn);
}); });
for (var i = 0; i < 11; i++) { for (let i = 0; i < 11; i++) {
(function(i) { file.write(`${i}`);
file.write('' + i);
})(i);
} }
process.on('exit', function() { process.on('exit', function() {
for (var k in callbacks) { for (const k in callbacks) {
assert.equal(0, callbacks[k], k + ' count off by ' + callbacks[k]); assert.strictEqual(0, callbacks[k], `${k} count off by ${callbacks[k]}`);
} }
console.log('ok'); console.log('ok');
}); });