1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

url: url.format() encodes all # in search

Browse Source 
This commit fixes an error where only the first occurrence of `#` in
`search` parameter is URL encoded, and subsequent occurrences are not.

Also added a test for the case.

Fixes: https://github.com/nodejs/node/issues/8064
PR-URL: https://github.com/nodejs/node/pull/8072
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Ilkka Myller 2016-08-11 23:17:16 +03:00 committed by James M Snell
parent 0abdf59f50
commit 1d0385f62d
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/url.js
View File

@ -624,7 +624,7 @@ Url.prototype.format = function() {
}
}
search = search.replace('#', '%23');
search = search.replace(/#/g, '%23');
if (hash && hash.charCodeAt(0) !== 35/*#*/) hash = '#' + hash;
if (search && search.charCodeAt(0) !== 63/*?*/) search = '?' + search;

13
test/parallel/test-url.js
View File

@ -1176,6 +1176,19 @@ var formatTests = {
pathname: '/fooA100%mBr',
},
// multiple `#` in search
'http://example.com/?foo=bar%231%232%233&abc=%234%23%235#frag': {
href: 'http://example.com/?foo=bar%231%232%233&abc=%234%23%235#frag',
protocol: 'http:',
slashes: true,
host: 'example.com',
hostname: 'example.com',
hash: '#frag',
search: '?foo=bar#1#2#3&abc=#4##5',
query: {},
pathname: '/'
},
// https://github.com/nodejs/node/issues/3361
'file:///home/user': {
href: 'file:///home/user',