1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: add crypto check to http2 tests

Browse Source 
When building --without-ssl and running the tests some of the http2 test
fail with the following error message:

internal/util.js:82
    throw new errors.Error('ERR_NO_CRYPTO');
    ^

Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto
support
    at Object.assertCrypto (internal/util.js:82:11)
    at internal/http2/core.js:5:26
    at NativeModule.compile (bootstrap_node.js:586:7)
    at NativeModule.require (bootstrap_node.js:531:18)
    at http2.js:17:5
    at NativeModule.compile (bootstrap_node.js:586:7)
    at Function.NativeModule.require (bootstrap_node.js:531:18)
    at Function.Module._load (module.js:449:25)
    at Module.require (module.js:517:17)
    at require (internal/module.js:11:18)

This commit adds hasCrypto checks and skips the tests if there is no
crypto support.

PR-URL: https://github.com/nodejs/node/pull/14657
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Daniel Bevenius 2017-08-07 07:54:44 +02:00 committed by James M Snell
parent f11379d25b
commit 1b719fe3d7
85 changed files with 178 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/parallel/test-http2-binding.js
View File

@ -1,7 +1,9 @@
// Flags: --expose-http2
'use strict';
require('../common');
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
assert.doesNotThrow(() => process.binding('http2'));

2
test/parallel/test-http2-client-data-end.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-client-destroy-before-connect.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const h2 = require('http2');
const server = h2.createServer();

2
test/parallel/test-http2-client-destroy-before-request.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-client-destroy.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-client-priority-before-connect.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const h2 = require('http2');
const server = h2.createServer();

2
test/parallel/test-http2-client-rststream-before-connect.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-client-set-priority.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-client-settings-before-connect.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-client-shutdown-before-connect.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const h2 = require('http2');
const server = h2.createServer();

2
test/parallel/test-http2-client-socket-destroy.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const h2 = require('http2');
const body =
'<html><head></head><body><h1>this is some data</h2></body></html>';

2
test/parallel/test-http2-client-stream-destroy-before-connect.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');
const NGHTTP2_INTERNAL_ERROR = h2.constants.NGHTTP2_INTERNAL_ERROR;

2
test/parallel/test-http2-client-unescaped-path.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const server = http2.createServer();

2
test/parallel/test-http2-client-upload.js
View File

@ -4,6 +4,8 @@
// Verifies that uploading data from a client works
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');
const fs = require('fs');

2
test/parallel/test-http2-client-write-before-connect.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-compat-serverrequest-headers.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-compat-serverrequest.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');
const net = require('net');

2
test/parallel/test-http2-compat-serverresponse-createpushresponse.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

4
test/parallel/test-http2-compat-serverresponse-end.js
View File

@ -1,7 +1,9 @@
// Flags: --expose-http2
'use strict';
const { mustCall, mustNotCall } = require('../common');
const { mustCall, mustNotCall, hasCrypto, skip } = require('../common');
if (!hasCrypto)
skip('missing crypto');
const { strictEqual } = require('assert');
const {
createServer,

2
test/parallel/test-http2-compat-serverresponse-finished.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-compat-serverresponse-flushheaders.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-compat-serverresponse-headers.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-compat-serverresponse-statuscode.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-compat-serverresponse-statusmessage-property.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-compat-serverresponse-statusmessage.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-compat-serverresponse-trailers.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

7
test/parallel/test-http2-compat-serverresponse-write-no-cb.js
View File

@ -1,7 +1,12 @@
// Flags: --expose-http2
'use strict';
const { mustCall, mustNotCall, expectsError } = require('../common');
const { mustCall,
mustNotCall,
expectsError,
hasCrypto, skip } = require('../common');
if (!hasCrypto)
skip('missing crypto');
const { throws } = require('assert');
const { createServer, connect } = require('http2');

2
test/parallel/test-http2-compat-serverresponse-writehead.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-connect-method.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const net = require('net');
const http2 = require('http2');

4
test/parallel/test-http2-connect.js
View File

@ -1,7 +1,9 @@
// Flags: --expose-http2
'use strict';
const { mustCall } = require('../common');
const { mustCall, hasCrypto, skip } = require('../common');
if (!hasCrypto)
skip('missing crypto');
const { doesNotThrow } = require('assert');
const { createServer, connect } = require('http2');

2
test/parallel/test-http2-cookies.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-create-client-connect.js
View File

@ -4,6 +4,8 @@
// Tests http2.connect()
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const fs = require('fs');
const h2 = require('http2');
const path = require('path');

2
test/parallel/test-http2-create-client-session.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');
const body =

2
test/parallel/test-http2-date-header.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-dont-override.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-getpackedsettings.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-goaway-opaquedata.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-head-request.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-info-headers.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-max-concurrent-streams.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-methods.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-misused-pseudoheaders.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-multi-content-length.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const server = http2.createServer();

2
test/parallel/test-http2-multiheaders.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-multiplex.js
View File

@ -5,6 +5,8 @@
// connection and makes sure that the data for each is appropriately echoed.
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-options-max-headers-block-length.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-options-max-reserved-streams.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const h2 = require('http2');
const server = h2.createServer();

2
test/parallel/test-http2-padding-callback.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');
const { PADDING_STRATEGY_CALLBACK } = h2.constants;

2
test/parallel/test-http2-priority-event.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-respond-file-204.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const assert = require('assert');
const path = require('path');

2
test/parallel/test-http2-respond-file-304.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const assert = require('assert');
const path = require('path');

2
test/parallel/test-http2-respond-file-compat.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const path = require('path');

2
test/parallel/test-http2-respond-file-fd-invalid.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const assert = require('assert');

2
test/parallel/test-http2-respond-file-fd-range.js
View File

@ -4,6 +4,8 @@
// Tests the ability to minimally request a byte range with respondWithFD
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const assert = require('assert');
const path = require('path');

2
test/parallel/test-http2-respond-file-fd.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const assert = require('assert');
const path = require('path');

2
test/parallel/test-http2-respond-file-push.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const assert = require('assert');
const path = require('path');

2
test/parallel/test-http2-respond-file-range.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const assert = require('assert');
const path = require('path');

2
test/parallel/test-http2-respond-file.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const assert = require('assert');
const path = require('path');

2
test/parallel/test-http2-response-splitting.js
View File

@ -6,6 +6,8 @@
// contain invalid characters.
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');
const { URL } = require('url');

2
test/parallel/test-http2-server-destroy-before-additional.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-server-destroy-before-push.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-server-destroy-before-respond.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-server-destroy-before-write.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-server-push-disabled.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-server-push-stream.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-server-rst-before-respond.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-server-rst-stream.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-server-set-header.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');
const body =

2
test/parallel/test-http2-server-shutdown-before-respond.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const h2 = require('http2');
const server = h2.createServer();

2
test/parallel/test-http2-server-socket-destroy.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const h2 = require('http2');
const assert = require('assert');

2
test/parallel/test-http2-server-socketerror.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-server-timeout.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const server = http2.createServer();

2
test/parallel/test-http2-session-settings.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-session-stream-state.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-single-headers.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const server = http2.createServer();

2
test/parallel/test-http2-status-code-invalid.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-status-code.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-timeouts.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const h2 = require('http2');
const server = h2.createServer();

2
test/parallel/test-http2-too-many-settings.js
View File

@ -5,6 +5,8 @@
// settings frames will result in a throw.
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

2
test/parallel/test-http2-trailers.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');
const body =

2
test/parallel/test-http2-window-size.js
View File

@ -7,6 +7,8 @@
// on smaller / IoT platforms in case this poses problems for these targets.
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

4
test/parallel/test-http2-withflag.js
View File

@ -1,7 +1,9 @@
// Flags: --expose-http2
'use strict';
require('../common');
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
assert.doesNotThrow(() => require('http2'));

2
test/parallel/test-http2-write-callbacks.js
View File

@ -4,6 +4,8 @@
// Verifies that write callbacks are called
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-write-empty-string.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

2
test/parallel/test-http2-zero-length-write.js
View File

@ -2,6 +2,8 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');