crypto: make LazyTransform compabile with Streams1
Makes LazyTransform writable by Streams1 by assigning .writable = true before the actual classes are loaded. Fixes: https://github.com/nodejs/node/issues/12269 PR-URL: https://github.com/nodejs/node/pull/12380 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
parent
9dcf18a5c0
commit
1ae172b272
@ -11,6 +11,8 @@ module.exports = LazyTransform;
|
|||||||
|
|
||||||
function LazyTransform(options) {
|
function LazyTransform(options) {
|
||||||
this._options = options;
|
this._options = options;
|
||||||
|
this.writable = true;
|
||||||
|
this.readable = true;
|
||||||
}
|
}
|
||||||
util.inherits(LazyTransform, stream.Transform);
|
util.inherits(LazyTransform, stream.Transform);
|
||||||
|
|
||||||
|
34
test/parallel/test-crypto-lazy-transform-writable.js
Normal file
34
test/parallel/test-crypto-lazy-transform-writable.js
Normal file
@ -0,0 +1,34 @@
|
|||||||
|
'use strict';
|
||||||
|
|
||||||
|
const common = require('../common');
|
||||||
|
const assert = require('assert');
|
||||||
|
const crypto = require('crypto');
|
||||||
|
const Stream = require('stream');
|
||||||
|
const util = require('util');
|
||||||
|
|
||||||
|
const hasher1 = crypto.createHash('sha256');
|
||||||
|
const hasher2 = crypto.createHash('sha256');
|
||||||
|
|
||||||
|
// Calculate the expected result.
|
||||||
|
hasher1.write(Buffer.from('hello world'));
|
||||||
|
hasher1.end();
|
||||||
|
|
||||||
|
const expected = hasher1.read().toString('hex');
|
||||||
|
|
||||||
|
function OldStream() {
|
||||||
|
Stream.call(this);
|
||||||
|
|
||||||
|
this.readable = true;
|
||||||
|
}
|
||||||
|
util.inherits(OldStream, Stream);
|
||||||
|
|
||||||
|
const stream = new OldStream();
|
||||||
|
|
||||||
|
stream.pipe(hasher2).on('finish', common.mustCall(function() {
|
||||||
|
const hash = hasher2.read().toString('hex');
|
||||||
|
assert.strictEqual(expected, hash);
|
||||||
|
}));
|
||||||
|
|
||||||
|
stream.emit('data', Buffer.from('hello'));
|
||||||
|
stream.emit('data', Buffer.from(' world'));
|
||||||
|
stream.emit('end');
|
Loading…
x
Reference in New Issue
Block a user