1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: use visibility("default") exports on POSIX

Browse Source 
Electron uses this because Chromium builds with symbols
hidden by default.

Refs:https://github.com/electron/node/commit/
88b494191c2a5b50b01dab80cd61ba3c0e0fbeb9
Refs: https://github.com/electron/node/commit/
1293d1d7d0c33d3925da11ceccdce4eb2e927a43

PR-URL: https://github.com/nodejs/node/pull/25893
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
This commit is contained in:
Jeremy Apthorp 2018-10-15 15:15:58 -07:00 committed by Daniel Bevenius
parent 3fe9267592
commit 1ac6ea2e6b
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/js_native_api.h
View File

@ -22,7 +22,7 @@
#ifdef _WIN32 #ifdef _WIN32
#define NAPI_EXTERN __declspec(dllexport) #define NAPI_EXTERN __declspec(dllexport)
#else #else
#define NAPI_EXTERN /* nothing */ #define NAPI_EXTERN __attribute__((visibility("default")))
#endif #endif
#endif #endif

2
src/node.h
View File

@ -29,7 +29,7 @@
# define NODE_EXTERN __declspec(dllimport) # define NODE_EXTERN __declspec(dllimport)
# endif # endif
#else #else
# define NODE_EXTERN /* nothing */ # define NODE_EXTERN __attribute__((visibility("default")))
#endif #endif
#ifdef BUILDING_NODE_EXTENSION #ifdef BUILDING_NODE_EXTENSION