1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tools: fix eslint isRequired

Browse Source 
Currently the call can lead to a TypeError with the message:
`Cannot read property 'value' of undefined`.

This fixes it by first checking that the first argument is truthy.

PR-URL: https://github.com/nodejs/node/pull/18729
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This commit is contained in:
Ruben Bridgewater 2018-02-12 12:31:23 +01:00
parent ba944b1697
commit 1a5f6705c6
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/eslint-rules/rules-utils.js
View File

@ -8,7 +8,7 @@
* require calls. * require calls.
*/ */
module.exports.isRequired = function(node, modules) { module.exports.isRequired = function(node, modules) {
return node.callee.name === 'require' && return node.callee.name === 'require' && node.arguments.length !== 0 &&
modules.includes(node.arguments[0].value); modules.includes(node.arguments[0].value);
}; };