diff --git a/src/node_crypto.cc b/src/node_crypto.cc index 54ccdabf144..37e28690d75 100644 --- a/src/node_crypto.cc +++ b/src/node_crypto.cc @@ -696,17 +696,18 @@ Handle Connection::GetPeerCertificate(const Arguments& args) { info->Set(fingerprint_symbol, String::New(fingerprint)); } - - STACK_OF(ASN1_OBJECT) *eku = (STACK_OF(ASN1_OBJECT) *)X509_get_ext_d2i(peer_cert, NID_ext_key_usage, NULL, NULL); + + STACK_OF(ASN1_OBJECT) *eku = (STACK_OF(ASN1_OBJECT) *)X509_get_ext_d2i( + peer_cert, NID_ext_key_usage, NULL, NULL); if (eku != NULL) { Local ext_key_usage = Array::New(); - + for (int i = 0; i < sk_ASN1_OBJECT_num(eku); i++) { memset(buf, 0, sizeof(buf)); OBJ_obj2txt(buf, sizeof(buf) - 1, sk_ASN1_OBJECT_value(eku, i), 1); ext_key_usage->Set(Integer::New(i), String::New(buf)); } - + sk_ASN1_OBJECT_pop_free(eku, ASN1_OBJECT_free); info->Set(ext_key_usage_symbol, ext_key_usage); } diff --git a/test/simple/test-tls-ext-key-usage.js b/test/simple/test-tls-ext-key-usage.js index da78868c226..75c376f4f27 100644 --- a/test/simple/test-tls-ext-key-usage.js +++ b/test/simple/test-tls-ext-key-usage.js @@ -110,11 +110,11 @@ function startClient() { console.log('client: connected+secure!'); console.log('client pair.cleartext.getPeerCertificate(): %j', pair.cleartext.getPeerCertificate()); - + // "TLS Web Client Authentication" - assert.equal(pair.cleartext.getPeerCertificate().ext_key_usage.length, 1) - assert.equal(pair.cleartext.getPeerCertificate().ext_key_usage[0], '1.3.6.1.5.5.7.3.2') - + assert.equal(pair.cleartext.getPeerCertificate().ext_key_usage.length, 1); + assert.equal(pair.cleartext.getPeerCertificate().ext_key_usage[0], '1.3.6.1.5.5.7.3.2'); + console.log('client pair.cleartext.getCipher(): %j', pair.cleartext.getCipher()); setTimeout(function() {