1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

dgram,process,util: refactor Error to TypeError

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/13857
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This commit is contained in:
Ruben Bridgewater 2017-06-21 20:23:37 +02:00 committed by Tobias Nießen
parent 1698c8e165
commit 1a452f1928
8 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/dgram.js
View File

@ -79,7 +79,7 @@ function newHandle(type) {
return handle; return handle;
} }
throw new errors.Error('ERR_SOCKET_BAD_TYPE'); throw new errors.TypeError('ERR_SOCKET_BAD_TYPE');
} }

2
lib/internal/process.js
View File

@ -181,7 +181,7 @@ function setupKillAndExit() {
if (lazyConstants()[sig]) { if (lazyConstants()[sig]) {
err = process._kill(pid, lazyConstants()[sig]); err = process._kill(pid, lazyConstants()[sig]);
} else { } else {
throw new errors.Error('ERR_UNKNOWN_SIGNAL', `${sig}`); throw new errors.TypeError('ERR_UNKNOWN_SIGNAL', sig);
} }
} }

2
lib/internal/util.js
View File

@ -180,7 +180,7 @@ function convertToValidSignal(signal) {
if (signalName) return signalName; if (signalName) return signalName;
} }
throw new errors.Error('ERR_UNKNOWN_SIGNAL', signal); throw new errors.TypeError('ERR_UNKNOWN_SIGNAL', signal);
} }
function getConstructorOf(obj) { function getConstructorOf(obj) {

2
test/parallel/test-child-process-constructor.js
View File

@ -68,6 +68,6 @@ assert(Number.isInteger(child.pid));
// try killing with invalid signal // try killing with invalid signal
assert.throws(() => { assert.throws(() => {
child.kill('foo'); child.kill('foo');
}, common.expectsError({ code: 'ERR_UNKNOWN_SIGNAL' })); }, common.expectsError({ code: 'ERR_UNKNOWN_SIGNAL', type: TypeError }));
assert.strictEqual(child.kill(), true); assert.strictEqual(child.kill(), true);

2
test/parallel/test-child-process-spawnsync-kill-signal.js
View File

@ -31,7 +31,7 @@ if (process.argv[2] === 'child') {
// Verify that an error is thrown for unknown signals. // Verify that an error is thrown for unknown signals.
assert.throws(() => { assert.throws(() => {
spawn('SIG_NOT_A_REAL_SIGNAL'); spawn('SIG_NOT_A_REAL_SIGNAL');
}, common.expectsError({ code: 'ERR_UNKNOWN_SIGNAL' })); }, common.expectsError({ code: 'ERR_UNKNOWN_SIGNAL', type: TypeError }));
// Verify that the default kill signal is SIGTERM. // Verify that the default kill signal is SIGTERM.
{ {

2
test/parallel/test-child-process-spawnsync-validation-errors.js
View File

@ -186,7 +186,7 @@ if (!common.isWindows) {
// Validate the killSignal option // Validate the killSignal option
const typeErr = /^TypeError: "killSignal" must be a string or number$/; const typeErr = /^TypeError: "killSignal" must be a string or number$/;
const unknownSignalErr = const unknownSignalErr =
common.expectsError({ code: 'ERR_UNKNOWN_SIGNAL' }); common.expectsError({ code: 'ERR_UNKNOWN_SIGNAL', type: TypeError });
pass('killSignal', undefined); pass('killSignal', undefined);
pass('killSignal', null); pass('killSignal', null);

2
test/parallel/test-dgram-createSocket-type.js
View File

@ -27,7 +27,7 @@ invalidTypes.forEach((invalidType) => {
dgram.createSocket(invalidType); dgram.createSocket(invalidType);
}, common.expectsError({ }, common.expectsError({
code: 'ERR_SOCKET_BAD_TYPE', code: 'ERR_SOCKET_BAD_TYPE',
type: Error, type: TypeError,
message: errMessage message: errMessage
})); }));
}); });

2
test/parallel/test-process-kill-pid.js
View File

@ -60,7 +60,7 @@ assert.throws(function() { process.kill(-1 / 0); },
// Test that kill throws an error for invalid signal // Test that kill throws an error for invalid signal
const unknownSignal = common.expectsError({ const unknownSignal = common.expectsError({
code: 'ERR_UNKNOWN_SIGNAL', code: 'ERR_UNKNOWN_SIGNAL',
type: Error, type: TypeError,
message: 'Unknown signal: test' message: 'Unknown signal: test'
}); });