1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: update author-ready label terms

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/23249
Refs: https://github.com/nodejs/node/pull/22255
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
Vse Mozhet Byt 2018-10-04 01:12:23 +03:00
parent 061e09891c
commit 1a18e3572e
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
COLLABORATOR_GUIDE.md
View File

@ -83,10 +83,11 @@ necessary.
### Author ready pull requests ### Author ready pull requests
A pull request that is still awaiting the minimum review time is considered A pull request that is still awaiting the minimum review time is considered
_author ready_ as soon as the CI has been started, it has at least one approval, _author ready_ as soon as the CI has been started, it has at least two approvals
and it has no outstanding review comments. Please always make sure to add the (one Collaborator approval is enough if the pull request has been open for more
`author ready` label to the PR in that case and remove it again as soon as that than 7 days), and it has no outstanding review comments. Please always make sure
condition is not met anymore. to add the `author ready` label to the PR in that case and remove it again as
soon as that condition is not met anymore.
### Handling own pull requests ### Handling own pull requests

3
doc/onboarding.md
View File

@ -99,7 +99,8 @@ onboarding session.
* Please add the `author-ready` label for PRs where: * Please add the `author-ready` label for PRs where:
* the CI has been started (not necessarily finished), * the CI has been started (not necessarily finished),
* no outstanding review comments exist and * no outstanding review comments exist and
* at least one collaborator approved the PR. * at least two Collaborators approved the PR (one Collaborator approval is
enough if the pull request has been open for more than 7 days).
* See [Who to CC in the issue tracker][who-to-cc]. * See [Who to CC in the issue tracker][who-to-cc].
* This will come more naturally over time * This will come more naturally over time