1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http2: be sure to destroy the Http2Stream

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/17406
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This commit is contained in:
James M Snell 2017-11-27 13:20:29 -08:00
parent ce38c49fb8
commit 18ca0b6442
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/node_http2.cc
View File

@ -619,13 +619,16 @@ inline int Http2Session::OnStreamClose(nghttp2_session* handle,
if (stream != nullptr) { if (stream != nullptr) {
stream->Close(code); stream->Close(code);
// It is possible for the stream close to occur before the stream is // It is possible for the stream close to occur before the stream is
// ever passed on to the javascript side. If that happens, ignore this. // ever passed on to the javascript side. If that happens, skip straight
// to destroying the stream
Local<Value> fn = Local<Value> fn =
stream->object()->Get(context, env->onstreamclose_string()) stream->object()->Get(context, env->onstreamclose_string())
.ToLocalChecked(); .ToLocalChecked();
if (fn->IsFunction()) { if (fn->IsFunction()) {
Local<Value> argv[1] = { Integer::NewFromUnsigned(isolate, code) }; Local<Value> argv[1] = { Integer::NewFromUnsigned(isolate, code) };
stream->MakeCallback(fn.As<Function>(), arraysize(argv), argv); stream->MakeCallback(fn.As<Function>(), arraysize(argv), argv);
} else {
stream->Destroy();
} }
} }
return 0; return 0;