1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove obsolete domain test

Browse Source 
test-microtask-queue-run-domain.js tests that the behavior of another
test, test-microtask-queue-run.js, is still consistent when the core
domain module is loaded.

This was needed because before the changes in #16222 were merged, the
core domain module would replace the function that would call nextTick
callbacks with a different implementation.

This is no longer the case, and therefore that test is no longer needed.

PR-URL: https://github.com/nodejs/node/pull/23343
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Julien Gilli 2018-10-08 17:22:10 -07:00
parent a3e604e9a3
commit 186ce7e837
1 changed files with 0 additions and 66 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
test/parallel/test-microtask-queue-run-domain.js
View File

@ -1,66 +0,0 @@
// Copyright Joyent, Inc. and other Node contributors.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the
// "Software"), to deal in the Software without restriction, including
// without limitation the rights to use, copy, modify, merge, publish,
// distribute, sublicense, and/or sell copies of the Software, and to permit
// persons to whom the Software is furnished to do so, subject to the
// following conditions:
//
// The above copyright notice and this permission notice shall be included
// in all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
'use strict';
require('../common');
const assert = require('assert');
// Requiring the domain module here changes the function that is used by node to
// call process.nextTick's callbacks to a variant that specifically handles
// domains. We want to test this specific variant in this test, and so even if
// the domain module is not used, this require call is needed and must not be
// removed.
require('domain');
function enqueueMicrotask(fn) {
Promise.resolve().then(fn);
}
let done = 0;
process.on('exit', function() {
assert.strictEqual(done, 2);
});
// no nextTick, microtask
setTimeout(function() {
enqueueMicrotask(function() {
done++;
});
}, 0);
// no nextTick, microtask with nextTick
setTimeout(function() {
let called = false;
enqueueMicrotask(function() {
process.nextTick(function() {
called = true;
});
});
setTimeout(function() {
if (called)
done++;
}, 0);
}, 0);